Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Chore: TM2.2 code cleaning, remove TAP-related and commented methods #157

Closed
5 tasks done
i-am-sijia opened this issue Jul 8, 2024 · 0 comments · Fixed by #159
Closed
5 tasks done

🧹 Chore: TM2.2 code cleaning, remove TAP-related and commented methods #157

i-am-sijia opened this issue Jul 8, 2024 · 0 comments · Fixed by #159
Assignees
Labels
chore overhead: doesn't add additional functionality, change performance, or refactor code

Comments

@i-am-sijia
Copy link
Collaborator

i-am-sijia commented Jul 8, 2024

When reviewing and cleaning travel-model-two-config, I deleted configs that are no longer used. See PR: BayAreaMetro/travel-model-two-config#8

Relevant tm2py code changes:

  • Required: update the config.py to drop the pydantic checks on configs that are removed. E.g.,

    tm2py/tm2py/config.py

    Lines 316 to 318 in c81ab14

    highway_maz_ctramp_output_file: pathlib.Path
    transit_tap_ctramp_output_file: pathlib.Path
    transit_taz_ctramp_output_file: pathlib.Path
  • Optional: delete the methods in tm2py that are no longer used in TM2.2. E.g.,
    # self._consolidate_demand_for_assign()

@gregerhardt @lmz @DavidOry Ok to do both?

Progress:

  • Sufficiently defined
  • Approach decided
  • Implemented

Considerations

Will need to run the model after these updates to make sure nothing breaks.

@i-am-sijia i-am-sijia added the chore overhead: doesn't add additional functionality, change performance, or refactor code label Jul 8, 2024
@i-am-sijia i-am-sijia self-assigned this Jul 8, 2024
@i-am-sijia i-am-sijia linked a pull request Jul 11, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore overhead: doesn't add additional functionality, change performance, or refactor code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants