Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Lint seems to invalidate the attached example incorrectly #1

Closed
tomknight85 opened this issue Sep 25, 2020 · 2 comments
Closed

Comments

@tomknight85
Copy link

Hi Bas,
Firstly, this is quite the handy plug-in. I'll be keeping my eye on future progress.

I have the attached csv file that encounters the invalidation that appears to be incorrect:
'Error line 165: Too few columns'

Using the Aug 05th release x64.

FTE RT Ledger Upload Aug 2020 Actuals.txt
image

Is this an internal error rather than an invalidation?

Cheers Tom

@tomknight85 tomknight85 changed the title CSV Lint seems to fail with the attached example CSV Lint seems to invalidate the attached example incorrectly Sep 25, 2020
@BdR76
Copy link
Owner

BdR76 commented Sep 25, 2020

Thanks, nice to hear you like it. I've initially created it for working with research and lab datasets, which can sometimes be a bit messy.

I saw that the x64 dll hasn't been updated since the very first upload, so I've refreshed both DLL files now.

However, that probably won't fix your issue. There are some problems in the way the plugin accesses the textfile through Scintilla. Especially when you edit the file and then press "Validate data" again, there seems to be some sort of caching issue, resulting in these "false positive" error messages. I haven't had time to dive into it, but properly fixing this will require a code overhaul, which btw could also boost performance on larger data files.

In short; the plugin works best when you have not edited the data file yet. So when you make edits, save the file, close the tab in Notepad++ and then reopen that file, that seems to work best for now.

@tomknight85
Copy link
Author

Thanks Bas,
The more recent x64 build has resolved the above issue.

We have a heap of interfacing systems that all implement various flavours of csv, this will come in handy - especially for those large files!

Thanks for the tips too. I also experienced the caching issue but it appears manageable to close the tab and reopen.
Cheers, Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants