Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop dword ptr [esp] #45

Open
Hendi48 opened this issue May 21, 2024 · 0 comments
Open

pop dword ptr [esp] #45

Hendi48 opened this issue May 21, 2024 · 0 comments

Comments

@Hendi48
Copy link

Hendi48 commented May 21, 2024

In #2 you applied a change that broke decoding of pop dword ptr [esp+displ].

  • 8F0F24 must be disassembled to pop dword ptr [esp], not pop dword ptr [esp+4]
  • 8F442404 must be disassembled to pop dword ptr [esp+4], not pop dword ptr [esp+8]
  • 8F8424F0000000 must be disassembled to pop dword ptr [esp+F0], not pop dword ptr [esp+F4]
  • and so on

While the current output might seem more "logical", it's a discrepancy from all other disassemblers and assemblers. Copying output from BeaEngine into an x86 assembler will result in a broken program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant