New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sum in error message must include a fee #360

Closed
jurijakimuk opened this Issue Jan 17, 2019 · 7 comments

Comments

Projects
5 participants
@jurijakimuk
Copy link
Member

jurijakimuk commented Jan 17, 2019

Bug description
When sending UTXO's and there are no available funds - the error message that shows the available amount of funds does not take into accout the fee.

To Reproduce
Preconditions:
A desktop wallet is installed and running.
There are some funds in the wallet.

  1. Navigate to the Send screen.
  2. Enter the amount that is slightly higher than available and a fee.
  3. Check the amount specified in the error message below the entered sum.

Current behaviour
The fee is not taken into account.

Expected behaviour
The fee is taken into account.

Platform and build

  • Windows
  • 10 x64
  • 4193 masternet

Screenshots (if applicable)
actual_amount
error_amount

@jurijakimuk jurijakimuk added this to To do in Agile Atom 1.2 via automation Jan 17, 2019

@anatolse anatolse moved this from To do to In progress in Agile Atom 1.2 Jan 18, 2019

anatolse added a commit that referenced this issue Jan 18, 2019

@anatolse anatolse moved this from In progress to Done in Agile Atom 1.2 Jan 18, 2019

@Sergei-Beam Sergei-Beam assigned Sergei-Beam and unassigned anatolse Jan 22, 2019

@sasha-abramovich

This comment has been minimized.

Copy link
Contributor

sasha-abramovich commented Jan 22, 2019

@alexandrashelenkova please provide a screenshot on how it should be done.

@Sergei-Beam Sergei-Beam moved this from Done to In progress in Agile Atom 1.2 Jan 23, 2019

@sasha-abramovich

This comment has been minimized.

Copy link
Contributor

sasha-abramovich commented Jan 23, 2019

suggested wording so far:
Insufficient funds: you would need XXX groth to complete the transaction.

@alexandrashelenkova

This comment has been minimized.

Copy link

alexandrashelenkova commented Jan 28, 2019

Here are some ideas that we might have use in the future
var 1
zpl.io/boKJnpZ
zpl.io/a3grZAY
zpl.io/2vKjLR7

var 2
zpl.io/bldO4KG
zpl.io/awW5BzM
zpl.io/29oGgmy

anatolse added a commit that referenced this issue Feb 4, 2019

@anatolse anatolse moved this from In progress to Done in Agile Atom 1.2 Feb 4, 2019

@jurijakimuk

This comment has been minimized.

Copy link
Member Author

jurijakimuk commented Feb 5, 2019

@sasha-abramovich Please see the screenshot below and decide how we display the amount in the warning message:
image
8_500_000_010 groths or 85 beams 10 groths ?
Thanks.

@jurijakimuk jurijakimuk removed their assignment Feb 5, 2019

@sasha-abramovich

This comment has been minimized.

Copy link
Contributor

sasha-abramovich commented Feb 5, 2019

When the amount is more than 5 digits groths please use beams - the devs should be aware of that "agreement" :)

@jurijakimuk

This comment has been minimized.

Copy link
Member Author

jurijakimuk commented Feb 5, 2019

@anatolse Anatol, please implement the logic of how the amount in the warning message is displayed. The amount up to 99999 groths is displayed in groths, e.g. "Insufficient funds: you would need 99999 groths to complete the transaction." (for 99999 groths) or "Insufficient funds: you would need 22 groths to complete the transaction." (for 22 groths)
The amount more than 99999 groths is displayed in beams, e.g. "Insufficient funds: you would need 0.00100055 beams to complete the transaction." (for 100055 groths) or "Insufficient funds: you would need 2.00204444 beams to complete the transaction." (for 200204444 groths)

@jurijakimuk jurijakimuk assigned anatolse and unassigned jurijakimuk Feb 5, 2019

@jurijakimuk jurijakimuk moved this from Done to To do in Agile Atom 1.2 Feb 5, 2019

@anatolse anatolse moved this from To do to In progress in Agile Atom 1.2 Feb 5, 2019

anatolse added a commit that referenced this issue Feb 5, 2019

@anatolse anatolse moved this from In progress to Done in Agile Atom 1.2 Feb 5, 2019

@jurijakimuk jurijakimuk assigned jurijakimuk and unassigned anatolse Feb 5, 2019

@jurijakimuk

This comment has been minimized.

Copy link
Member Author

jurijakimuk commented Feb 5, 2019

Works OK, tested on 4357, master

@jurijakimuk jurijakimuk closed this Feb 5, 2019

Agile Atom 1.2 automation moved this from Done to Tested Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment