Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one generic parameter instead of different import_path and export_path #430

Closed
jurijakimuk opened this issue Jan 29, 2019 · 3 comments
Closed

Use one generic parameter instead of different import_path and export_path #430

jurijakimuk opened this issue Jan 29, 2019 · 3 comments
Assignees
@jurijakimuk
Labels
cli Issues related to CLI Wallet task Something new to develop

Comments

@jurijakimuk
Copy link

jurijakimuk commented Jan 29, 2019 •
edited
Loading

Task description
Currently we have two parameters import_path and export_path. And they are interchangeable. It means, beam-wallet export_addresses --export_path=... and beam-wallet export_addresses --import_path=... are both valid commands and do the same job. The purpose of the task is to have one parameter.

Current behaviour
--export_path=... and --import_path=... do the same thing.

Expected behaviour
There's only one parameter for that, e.g. --path or something like that.
@jurijakimuk jurijakimuk added task Something new to develop cli Issues related to CLI Wallet labels Jan 30, 2019
@jurijakimuk jurijakimuk changed the title assignee: jurijakimuk Use one generic parameter instead of different import_path and export_path Jan 30, 2019
@anatolse anatolse assigned roman-strilets and unassigned anatolse Jan 30, 2019
@gingervik
Copy link
Member

part of #346

roman-strilets added a commit that referenced this issue Feb 4, 2019
@roman-strilets
#430 used file_location instead of import_path or export_path
21ab508
@roman-strilets
Copy link
Member

examples:
beam-wallet.exe export_addresses --file_location="..."
beam-wallet.exe import_addresses --file_location="..."

@gingervik gingervik assigned jurijakimuk and unassigned gingervik Feb 4, 2019
@jurijakimuk
Copy link
Author

Tested on master, 4346. Works OK. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jurijakimuk jurijakimuk

Labels
cli Issues related to CLI Wallet task Something new to develop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anatolse @gingervik @roman-strilets @jurijakimuk