-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capture only user-specified arkouda commands on client #2702
Labels
enhancement
New feature or request
Comments
hokiegeek2
added a commit
to hokiegeek2/arkouda
that referenced
this issue
Aug 22, 2023
hokiegeek2
added a commit
to hokiegeek2/arkouda
that referenced
this issue
Aug 22, 2023
…ule accordingly, added pydocs Bears-R-Us#2702
hokiegeek2
added a commit
to hokiegeek2/arkouda
that referenced
this issue
Aug 22, 2023
hokiegeek2
added a commit
to hokiegeek2/arkouda
that referenced
this issue
Aug 22, 2023
hokiegeek2
added a commit
to hokiegeek2/arkouda
that referenced
this issue
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Description
The recently added command logging logs incoming commands along with any corresponds command arguments and requesting user. Client-side debug logging has demonstrated there are some implementation details that negatively impact the efficacy for command logging.
One example is the client invocation of ak.ones() results in three separate client server calls, none of which are called ones:
Looking at the ak.ones code, the invocations are as follows:
In another example, ak.unique starts with the unique command which is followed by multiple delete commands deleting intermediate arrays along with a call to __repr__:
A possible enhancement would be to log all commands as submitted by the user via the client. One approach satisfies one of the command logging use cases--namely, to capture all commands within a workflow for later use in a non-interactive setting such as as cron job--is to generate and capture the command history within the Python client. Longer-term, being able to precisely capture solely user-specified commands server-side will require additional message metadata and processing logic. However, this issue is designed to satisfy the above-mentioned use case.
The text was updated successfully, but these errors were encountered: