Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2702: Capture only user-specified arkouda commands on client #2707

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Closes #2702: Capture only user-specified arkouda commands on client #2707

merged 7 commits into from
Aug 22, 2023

Conversation

hokiegeek2
Copy link
Contributor

Closes #2702

This PR adds the following:

  1. history module containing a base abstract HistoryRetriever and two derived classes that retrieve Python command history
  2. ShellHistoryRetriever that retrieves Python command history from Python REPL shell
  3. NotebookHistoryRetriever that retrieves Python command history from Jupyter notebook and IPython shells
  4. Integration of HistoryRetriever classes into client module via generate_history method

stress-tess
stress-tess reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than one probably unintentional edit to the get_mem_avail docstring

arkouda/client.py Outdated Show resolved Hide resolved
arkouda/history.py Show resolved Hide resolved
@stress-tess stress-tess changed the title capture only user-specified arkouda commands on client closes #2702: Capture only user-specified arkouda commands on client Aug 22, 2023
@stress-tess stress-tess changed the title closes #2702: Capture only user-specified arkouda commands on client Closes #2702: Capture only user-specified arkouda commands on client Aug 22, 2023
stress-tess
stress-tess reviewed Aug 22, 2023
View reviewed changes
arkouda/client.py Outdated Show resolved Hide resolved
jaketrookman
jaketrookman approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@stress-tess stress-tess added this pull request to the merge queue Aug 22, 2023
Merged via the queue into Bears-R-Us:master with commit 1168084 Aug 22, 2023
9 checks passed
@hokiegeek2 hokiegeek2 deleted the 2702_capture_only_user-specified_arkouda_commands_on_client branch March 27, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketrookman jaketrookman jaketrookman approved these changes

@stress-tess stress-tess stress-tess approved these changes

@TheOddCzar789 TheOddCzar789 Awaiting requested review from TheOddCzar789

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

capture only user-specified arkouda commands on client
3 participants
@hokiegeek2 @stress-tess @jaketrookman