Fixed TreeBuilder #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if there's something else you would like me to change ;) |
Oliboy50
approved these changes
Feb 16, 2020
| @@ -18,8 +18,13 @@ class Configuration implements ConfigurationInterface | |||
| */ | |||
| public function getConfigTreeBuilder() | |||
| { | |||
| $treeBuilder = new TreeBuilder(); | |||
| $rootNode = $treeBuilder->root('m6_statsd'); | |||
| if (method_exists(new TreeBuilder(), 'getRootNode')) { | |||
There was a problem hiding this comment.
there's already a PR opened for this: #70
| ->thenInvalid("address parameter should begin with 'udp://'") | ||
| ->end() | ||
| ->end() | ||
| ->scalarNode('address')->isRequired()->end() |
There was a problem hiding this comment.
I'm not sure why you've removed this validation, but it shouldn't hurt anyway 🤷♂
There was a problem hiding this comment.
for some reason, when I set it up like this, the validation fails:
m6_statsd:
servers:
default:
address: '%env(STATSD_SERVER)%'
port: '%env(int:STATSD_PORT)%'
clients:
default:
servers: ['default']
even tho those are setup correctly with udp:// in my env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.