Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB Ignore] Monkey to species, take 2 #10943

Open
wants to merge 64 commits into
base: master
Choose a base branch
from

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented May 7, 2024

About The Pull Request

Title.

closes #8376
closes #9120

Recoup of #10156

Reverts #6694, #8962 as they are now obsolete.

Basically, monkeys are species, with all that entails. We are throwing the shitcode away that needed like 10 different refactors over 3 years to deal with, cause the code is fundamentally garbo.

Humans and Monkeys are already interconnected, no way out of it, so we might as well make the code sane.

Basically, we can make monkeys functionally identical to humans, but we need several explicit drawbacks.

  • Absolutely no consoles.
  • Probably cant understand most electronic tools
  • Some weapon restrictions or two.
  • Not roundstart race

Lmk if theres any others that tickle your noggin that you think would make this change make them "OP"

TODO

  • Either fix teratomas or just remove them. Terrible duplicated shitcode.
  • fix clothing layering offsets (its kinda annoying to work with, pursuing TG's filter system if Racc doesnt respond)
  • audit monkey dexterity
  • audit monkeyize() & humanize()

Ports:

Why It's Good For The Game

No more aheals when changing race

Hunger is persistent when changing between monkey and humans

All stat vars are not reset inbetween transformations

woaw, genetics dont SUCK

Monkey organs dont runtime the fuck out when they try and do species stuff (who put HUMAN organs inside CARBONS!!!?!)

Testing Photographs and Procedure

Screenshots&Videos

Roundstart monkey ---> human

dreamseeker_Tra1IvQGA8.mp4

Roundstart human ---> monkey

dreamseeker_4IPYBkJiVb.mp4

Monkeys can hold and use two handed weapons, but they do not have the upper core strength to use both arms as a human would.

dreamseeker_q0DYwJi9r9.mp4

Changelog

🆑 DrDuckedGoose(species design & appearance) rkz(balancing and mass conversions), qustinnus, coiax, IndieanaJones
add: monkeys are now species
add: monkey tails are now handled like actual tail organs, rather than just being a sprite. They apply and are subtyped the exact same way catgirl tails are, minus a wag animation.
balance: Monkeys can do a lot more things
code: converted mob ventcrawling into flags/traits
/:cl:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this probably the only file that needs any major revisions. Namely, adding back teratomas (in a sane manner)

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor Author

fuck it, lets just fold monkey tails into human tails instead of their own snowflake

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat Tsar-Salat changed the title Monkey to species, take 2 [MDB Ignore] Monkey to species, take 2 Sep 28, 2024
Copy link

github-actions bot commented Oct 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Oct 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monkeys are immune to heart attacks. Converting someone into a monkey then human heals them
5 participants