Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors monkeys into a species #10156

Closed
wants to merge 8 commits into from

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Nov 7, 2023

Ports:

About The Pull Request

closes #9120

closes #8376

closes #9017

Makes monkeys a subtype of humans

TODO:

  • No conflicts
  • Monkeys inherit hunger
  • Monkeys inherit health
  • monkey correct transformation animations
  • correct teratoma transformation
  • check monkey emotes
  • genes work on humans & monkeys

Why It's Good For The Game

No more transform_proc bullshit, with health all a bunch of other junk failing to inherit (free aheal!).

Less snowflake code. We dont have to account for how monkeys have the same organ and limbcode as regular humans but weird and gutted.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 rkz, Qustinnus
refactor: monkeys are now a species
fix: no more free aheal when transforming between monkey and human
fix: monkey transformations should carry all organ and mob data that normal species transformations do
fix: you can no longer nullspace yourself with a cerulean extract through monkeyfying yourself
/:cl:

Copy link

github-actions bot commented Dec 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@aramix273
Copy link
Contributor

while it would solve #9017 based on the replication steps offered in the bug report, the underlying cause would still persist, as another option to cause that bug is to use advanced mutation toxin (the one that turns you into a simplemob slime) instead of a monkified mutator, which would also cause the same effects to be perceived

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor Author

im too stupid to figure this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants