Add Admin Fax System #70072

twilightwanderer · 2022-09-22T11:03:27Z

About The Pull Request

Thanks to @kawoppi for giving me the opportunity to finish my implementation.

From the moment I put the fax functionality in the build, I planned the implementation of this system. The only reason I didn't do it right away was because I wanted to see how relevant the fax mechanics would be in the build. And now I'm ready to present my implementation of a fax messaging system similar to the Requests Manager system.

Why It's Good For The Game

With this system, players will be able to send messages to a specially generated list of virtual faxes when accessed or hacked, and administrators will be able to read messages and send responses.

Changelog

🆑
add: Ability to send and receive administrator fax messages.
admin: Panel for easy viewing and sending messages to faxes.
/:cl:

github-actions · 2022-09-22T11:03:50Z

You currently have a negative Fix/Feature pull request delta of -8. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

Jolly-66 · 2022-09-22T11:08:07Z

The CC and Syndicate colors look extremely offensive, could you tone them back a bit? Clown Planet too but yellow is.. a color.

twilightwanderer · 2022-09-22T11:11:12Z

The CC and Syndicate colors look extremely offensive, could you tone them back a bit? Clown Planet too but yellow is.. a color.

Correction, this is an example showing that TG-based assemblies can set their own list of faxes.

Miczu555PL · 2022-09-22T12:08:18Z

The CC and Syndicate colors look extremely offensive, could you tone them back a bit? Clown Planet too but yellow is.. a color.

Correction, this is an example showing that TG-based assemblies can set their own list of faxes.

White text on neon bright color. 💀

kawoppi · 2022-09-22T12:11:00Z

If I'm understanding that second screenshot correctly you can write faxes with the menu, that's really useful! Does it also allow you to use paper markdown when writing a fax that way?

twilightwanderer · 2022-09-22T13:04:33Z

If I'm understanding that second screenshot correctly you can write faxes with the menu, that's really useful! Does it also allow you to use paper markdown when writing a fax that way?

Yes. The paper is based on plain HTML. I originally tried to do a preview, but I couldn't beat the FPS sagging.

code/modules/admin/admin_verbs.dm

JohnFulpWillard · 2022-09-24T06:57:56Z

code/modules/paperwork/fax.dm

+	if(access_additional_faxes_check(user))
+		access_additional_faxes_toggle()


This is weird, why don't we just let them see the faxes while they're on the UI with the required access? Maybe as a dropdown menu on it, so they're more on the UI rather than the physical object.

I used the same concept as with the Request Console. Only the captain can speak for the station. His card can be used to enable or disable access. For example, you can ask him to do it or steal his card. When activated, the access will be permanent for people who do not have access.

Logging in to a console is pretty different than this case, I feel this will just make the feature obscure to people.

I can leave a hint in the description or make an authorization button.

code/modules/paperwork/fax.dm

code/modules/paperwork/fax_manager.dm

JohnFulpWillard · 2022-09-24T07:06:19Z

code/_globalvars/lists/faxes.dm

+GLOBAL_LIST_INIT(additional_faxes_list, list(
+	list("fax_name" = "Central Command", "button_color" = "#34c924"),
+	list("fax_name" = "Clown Planet", "button_color" = "#f4c800"),
+))
+
+GLOBAL_LIST_INIT(syndicate_faxes_list, list(
+	list("fax_name" = "Syndicate Coordination Center", "button_color" = "#ff0000"),
+	list("fax_name" = "Federation of Wizards", "button_color" = "#8b00ff"),
+	list("fax_name" = "Nar-Sie Church", "button_color" = "#8b0000"),
+))


While this seems nice, I don't think I agree with it being in-game, unless you change the methods to gain these.
My thinking is limiting individual faxes to specific accesses (Centcom is Cap/Lawyer, Clown planet is Clown, Syndicate is Syndie access (the one that Agent IDs have), Nar'Sie could be maybe a culted fax using twisted construction, wizard federation I can't really explain at all).

I understand your criticism. But I still want to defend my approach. First of all, I'm afraid that organizing access for each role would make the system very complicated. Secondly, giving access to certain facsimiles for certain roles will narrow the framework for role-playing. I see no reason to limit the captain to be able to write complaints to Planet of the Clowns, and the clown to write unfunny jokes for the CC. Third, I created the list specifically based on requests from developers of other builds based on TG. They would like to be able to designate their own organizations and factions for their servers. For TG, I entered such organizations for example, and nothing stops them from tweaking or deleting.

code/modules/admin/admin_verbs.dm

code/modules/admin/verbs/fax.dm

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>

…tation into fax-manager

JohnFulpWillard

I'm fine with the different organizations you can contact, but my opinion hasn't changed two things:

A dropdown menu with the admin faxes, to separate admins with player-faxes, especially since oranges had requested the ability to fax other stations (servers, so terry faxing sybil, ect), I would like it if admin ones weren't also filling up the space in such case.
No login needed on a fax, you just access it when you have the access on your ID, I think faxes are closer to access carded doors than secure command communication consoles used to call for emergencies..

github-actions · 2022-10-09T00:24:29Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

twilightwanderer · 2022-10-11T07:11:41Z

I still don't understand why players need to be restricted in this way.

I'm shamelessly using [this port](BeeStation/BeeStation-Hornet#8821) as a guide. Credit to them for their great work. This PR constantly reminds me to work on it.   ## About The Pull Request Fixes #1658. Updates the papercode to be somewhat more in-line with TG's own. Objective is to port the following pull requests: * [x] Papercode * * [x] tgstation/tgstation#68612 * * [x] tgstation/tgstation#69071 * * [x] tgstation/tgstation#63879 (a small part of it. i'm not doing this) * * [x] tgstation/tgstation#73628 * * [x] tgstation/tgstation#72367 * * [x] tgstation/tgstation#73633 * [x] Photocopier Improvements (we already have this ported, we just need to get it up to date) * * [x] tgstation/tgstation#61323 * * [x] tgstation/tgstation#63287 * * [x] tgstation/tgstation#69198 * * [x] tgstation/tgstation#69005 * * ~~custom shiptest forms~~ going to be put into a different pr * [x] Fax Machines * * [x] figure out why it's broken (it's a whitesands system from oracle. i'm replacing it entirely) * * [x] tgstation/tgstation#69397 * * [x] tgstation/tgstation#69554 * * [x] tgstation/tgstation#69651 * * [x] tgstation/tgstation#70072 * * [x] tgstation/tgstation#71262 * * [x] fix issues with logging and following * * [x] make fax machines be properly named * * [x] custom admin fax recipients * [x] make it not break interviews  ## Why It's Good For The Game Fax machines have been broken for a good while. Recent re-introduction of SolGov into the game, a very bureaucratic entity, demands better paperwork. Annoy admins, send threats, shurikens and pizza through fax. Admins don't have to use NanoPrayer:tm: anymore. Kansatsu funnies. Inteq binding contracts. Send pictures of your ass to everyone in the sector. Get hunted down by the paperwork police for sending pictures of your ass to everyone in the sector.  ## Changelog :cl: Bobbanz1, Timberpoes, SteelSlayer, twilightwanderer, ShizCalev, timothymtorres, Imaginos16, dragomagol, Jacquerel, Mothblocks, ThePotato97, LemonInTheDark, ported by MeeMOfCourse qol: AIs now see the full paper interface when players show them papers through the camera, exactly what's written on the paper, fully rendered. refactor: Paper code has been completely refactored. fix: Fixes signatures not working at all. Signatures now only work when %s or %sign is put into an [___] input field. fix: Input fields are now fixed and also work again. fix: Fixes markdown paragraphing not working in paper code. tweak: You can insert any type of toner cartridge into photocopiers, and regardless of the currently inserted toner's charge level. tweak: Toner cartridges can be ejected from photocopiers at any time add: Added a system of forms and the ability to print them fix: Hints in bureaucracy forms add: Added new VOID stamp tweak: switches old oracle fax machine with tg's fax machine system fix: Fixes faxes playing the "fax_contain" animation and makes it actually use the "fax_receive" animation when receiving. imageadd: Resprites fax machines! admin: fax messages and book printings are now logged in paper.log admin: renaming fax machines is logged in game log add: You can now send photos or trading cards through the fax machine. add: You can now hack the wires of a fax machine to have it throw items harder or accept additional flat input items such as material sheets, ID cards, and pizza slices. add: Ability to send and receive administrator fax messages. admin: Panel for easy viewing and sending messages to faxes. fix: Fixes a crash of TGUI fax panel when there is no fax in the network fix: Fixes a crash of the Fax Manager panel when there is no fax machines in the network. fix: You can no longer remove the toner cartridge from a printer while it's busy printing. /:cl:   --------- Signed-off-by: meemofcourse <75212565+meemofcourse@users.noreply.github.com>

I'm shamelessly using [this port](BeeStation/BeeStation-Hornet#8821) as a guide. Credit to them for their great work. This PR constantly reminds me to work on it.   ## About The Pull Request Fixes shiptest-ss13#1658. Updates the papercode to be somewhat more in-line with TG's own. Objective is to port the following pull requests: * [x] Papercode * * [x] tgstation/tgstation#68612 * * [x] tgstation/tgstation#69071 * * [x] tgstation/tgstation#63879 (a small part of it. i'm not doing this) * * [x] tgstation/tgstation#73628 * * [x] tgstation/tgstation#72367 * * [x] tgstation/tgstation#73633 * [x] Photocopier Improvements (we already have this ported, we just need to get it up to date) * * [x] tgstation/tgstation#61323 * * [x] tgstation/tgstation#63287 * * [x] tgstation/tgstation#69198 * * [x] tgstation/tgstation#69005 * * ~~custom shiptest forms~~ going to be put into a different pr * [x] Fax Machines * * [x] figure out why it's broken (it's a whitesands system from oracle. i'm replacing it entirely) * * [x] tgstation/tgstation#69397 * * [x] tgstation/tgstation#69554 * * [x] tgstation/tgstation#69651 * * [x] tgstation/tgstation#70072 * * [x] tgstation/tgstation#71262 * * [x] fix issues with logging and following * * [x] make fax machines be properly named * * [x] custom admin fax recipients * [x] make it not break interviews  ## Why It's Good For The Game Fax machines have been broken for a good while. Recent re-introduction of SolGov into the game, a very bureaucratic entity, demands better paperwork. Annoy admins, send threats, shurikens and pizza through fax. Admins don't have to use NanoPrayer:tm: anymore. Kansatsu funnies. Inteq binding contracts. Send pictures of your ass to everyone in the sector. Get hunted down by the paperwork police for sending pictures of your ass to everyone in the sector.  ## Changelog :cl: Bobbanz1, Timberpoes, SteelSlayer, twilightwanderer, ShizCalev, timothymtorres, Imaginos16, dragomagol, Jacquerel, Mothblocks, ThePotato97, LemonInTheDark, ported by MeeMOfCourse qol: AIs now see the full paper interface when players show them papers through the camera, exactly what's written on the paper, fully rendered. refactor: Paper code has been completely refactored. fix: Fixes signatures not working at all. Signatures now only work when %s or %sign is put into an [___] input field. fix: Input fields are now fixed and also work again. fix: Fixes markdown paragraphing not working in paper code. tweak: You can insert any type of toner cartridge into photocopiers, and regardless of the currently inserted toner's charge level. tweak: Toner cartridges can be ejected from photocopiers at any time add: Added a system of forms and the ability to print them fix: Hints in bureaucracy forms add: Added new VOID stamp tweak: switches old oracle fax machine with tg's fax machine system fix: Fixes faxes playing the "fax_contain" animation and makes it actually use the "fax_receive" animation when receiving. imageadd: Resprites fax machines! admin: fax messages and book printings are now logged in paper.log admin: renaming fax machines is logged in game log add: You can now send photos or trading cards through the fax machine. add: You can now hack the wires of a fax machine to have it throw items harder or accept additional flat input items such as material sheets, ID cards, and pizza slices. add: Ability to send and receive administrator fax messages. admin: Panel for easy viewing and sending messages to faxes. fix: Fixes a crash of TGUI fax panel when there is no fax in the network fix: Fixes a crash of the Fax Manager panel when there is no fax machines in the network. fix: You can no longer remove the toner cartridge from a printer while it's busy printing. /:cl:   --------- Signed-off-by: meemofcourse <75212565+meemofcourse@users.noreply.github.com>

…CentCom (#2653)   ## About The Pull Request This pull requests ports: * BeeStation/BeeStation-Hornet#9408 * BeeStation/BeeStation-Hornet#9236 This pull request reverts: * tgstation/tgstation#70072 The requests manager is now a thing. ![264860380-6d27a710-8ac1-4864-9abe-4c13f4885cba](https://github.com/shiptest-ss13/Shiptest/assets/75212565/dc3277d3-9770-4450-97a8-6b4b918cf25b) It also adds little offices with fax machines for factions to CentCom, which recieve the physical paper and can send faxes back (though admins can still make use of the fax panel). ![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/1abb223f-1914-4ab9-8240-e2969a4e47f5) They can also fax each other, if ever needed. ![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/1d551e8e-cbea-4116-a608-f319411484b6)  ## Why It's Good For The Game * Gives admins the ability to see a very easy to use recap of all requests that occur in a round. This system is readily extendible to support other types of requests, should someone care to add it. * Better admin tools, admins can now send faxes directly via the new Fax Manager verb, and faxes are show in the request panel instead of its own panel. * You can now LARP as a Cybersun minimum wage intern handling faxes.  ## Changelog :cl: bobbahbrown, itsmeow, meemofcourse add: CentCom now has some small offices, which recieve physical faxes. add: Fax machines now announce that they have received a fax over radio. add: Fax machines announce important faxes VERY LOUDLY. balance: Faxes no longer require a subspace ansible crystal. code: Faxes now use typepath instead of varedit. tweak: Changed how special/faction faxes work. Login is no longer required to use special faxes. admin: Add Requests Manager to view all fax messages/prayers/centcom and syndicate requests/and nuke code requests within a round. admin: Removed old fax manager in favor of Requests Manager, added "Send Fax Message" verb to send admin faxes via a menu. fix: Fixed runtime when ghosts tried to view paper. /:cl:

…CentCom (shiptest-ss13#2653)   ## About The Pull Request This pull requests ports: * BeeStation/BeeStation-Hornet#9408 * BeeStation/BeeStation-Hornet#9236 This pull request reverts: * tgstation/tgstation#70072 The requests manager is now a thing. ![264860380-6d27a710-8ac1-4864-9abe-4c13f4885cba](https://github.com/shiptest-ss13/Shiptest/assets/75212565/dc3277d3-9770-4450-97a8-6b4b918cf25b) It also adds little offices with fax machines for factions to CentCom, which recieve the physical paper and can send faxes back (though admins can still make use of the fax panel). ![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/1abb223f-1914-4ab9-8240-e2969a4e47f5) They can also fax each other, if ever needed. ![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/1d551e8e-cbea-4116-a608-f319411484b6)  ## Why It's Good For The Game * Gives admins the ability to see a very easy to use recap of all requests that occur in a round. This system is readily extendible to support other types of requests, should someone care to add it. * Better admin tools, admins can now send faxes directly via the new Fax Manager verb, and faxes are show in the request panel instead of its own panel. * You can now LARP as a Cybersun minimum wage intern handling faxes.  ## Changelog :cl: bobbahbrown, itsmeow, meemofcourse add: CentCom now has some small offices, which recieve physical faxes. add: Fax machines now announce that they have received a fax over radio. add: Fax machines announce important faxes VERY LOUDLY. balance: Faxes no longer require a subspace ansible crystal. code: Faxes now use typepath instead of varedit. tweak: Changed how special/faction faxes work. Login is no longer required to use special faxes. admin: Add Requests Manager to view all fax messages/prayers/centcom and syndicate requests/and nuke code requests within a round. admin: Removed old fax manager in favor of Requests Manager, added "Send Fax Message" verb to send admin faxes via a menu. fix: Fixed runtime when ghosts tried to view paper. /:cl:

Add manager system

91e6f3f

tgstation-server added Administration As generous gods, we have deigned to throw the jannies a bone Feature Exposes new bugs in interesting ways UI We make the game less playable, but with round edges labels Sep 22, 2022

github-actions bot requested a review from stylemistake September 22, 2022 11:04

Correcting Formation

00d2e05

Minor edits

2487989

JohnFulpWillard reviewed Sep 24, 2022

View reviewed changes

JohnFulpWillard marked this pull request as draft September 24, 2022 07:08

twilightwanderer and others added 7 commits September 25, 2022 08:49

Renaming functions for better understanding

9c90210

Separation of static and dynamic data

c272fff

Combining the same actions into a procedure

a49390d

Update code/modules/admin/verbs/fax.dm

edc14be

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>

Update code/modules/paperwork/fax_manager.dm

bb9da01

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>

Merge branch 'fax-manager' of https://github.com/twilightwanderer/tgs…

fc8fcf9

…tation into fax-manager

Documentation

cf07582

twilightwanderer marked this pull request as ready for review September 25, 2022 08:19

Adding an authorization button

5162445

twilightwanderer requested review from JohnFulpWillard and removed request for stylemistake September 27, 2022 09:50

JohnFulpWillard requested changes Oct 1, 2022

View reviewed changes

JohnFulpWillard marked this pull request as draft October 1, 2022 16:39

github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Oct 9, 2022

twilightwanderer closed this Oct 11, 2022

Bobbanz1 mentioned this pull request Nov 2, 2022

[PORT] Faxes from TG BeeStation/NSV13#2131

Closed

20 tasks

Bobbanz1 mentioned this pull request Nov 24, 2022

[PORT] HoP Expansion Pack - Papers Please Edition BeeStation/BeeStation-Hornet#8113

Closed

26 tasks

itsmeow mentioned this pull request Apr 7, 2023

Re-PR HoP Expansion Pack BeeStation/BeeStation-Hornet#8821

Merged

26 tasks

SinguloMirrorbot mentioned this pull request May 17, 2023

[MIRROR] Re-PR HoP Expansion Pack SinguloStation13/SinguloStation13#829

Closed

26 tasks

itsmeow mentioned this pull request Jun 23, 2023

[s] Fix fax machine href exploit BeeStation/BeeStation-Hornet#9297

Merged

itsmeow mentioned this pull request Jul 14, 2023

Fax Machine Requests Redo BeeStation/BeeStation-Hornet#9408

Merged

meemofcourse mentioned this pull request Jul 29, 2023

Updates Paperwork Code shiptest-ss13/Shiptest#2212

Merged

23 tasks

meemofcourse mentioned this pull request Sep 1, 2023

Updates Paperwork Code Pt. 2 shiptest-ss13/Shiptest#2323

Closed

16 tasks

meemofcourse mentioned this pull request Jan 21, 2024

Ports the Requests Manager, Minor Fax QOL, Adds factional offices to CentCom shiptest-ss13/Shiptest#2653

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Admin Fax System #70072

Add Admin Fax System #70072

twilightwanderer commented Sep 22, 2022 •

edited

github-actions bot commented Sep 22, 2022

Jolly-66 commented Sep 22, 2022

twilightwanderer commented Sep 22, 2022

Miczu555PL commented Sep 22, 2022

kawoppi commented Sep 22, 2022

twilightwanderer commented Sep 22, 2022 •

edited

JohnFulpWillard Sep 24, 2022

twilightwanderer Sep 25, 2022

JohnFulpWillard Sep 25, 2022

twilightwanderer Sep 25, 2022

JohnFulpWillard Sep 24, 2022

twilightwanderer Sep 25, 2022

JohnFulpWillard left a comment

github-actions bot commented Oct 9, 2022

twilightwanderer commented Oct 11, 2022

		if(access_additional_faxes_check(user))
		access_additional_faxes_toggle()

Add Admin Fax System #70072

Add Admin Fax System #70072

Conversation

twilightwanderer commented Sep 22, 2022 • edited

About The Pull Request

Why It's Good For The Game

Changelog

github-actions bot commented Sep 22, 2022

Jolly-66 commented Sep 22, 2022

twilightwanderer commented Sep 22, 2022

Miczu555PL commented Sep 22, 2022

kawoppi commented Sep 22, 2022

twilightwanderer commented Sep 22, 2022 • edited

JohnFulpWillard Sep 24, 2022

Choose a reason for hiding this comment

twilightwanderer Sep 25, 2022

Choose a reason for hiding this comment

JohnFulpWillard Sep 25, 2022

Choose a reason for hiding this comment

twilightwanderer Sep 25, 2022

Choose a reason for hiding this comment

JohnFulpWillard Sep 24, 2022

Choose a reason for hiding this comment

twilightwanderer Sep 25, 2022

Choose a reason for hiding this comment

JohnFulpWillard left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 9, 2022

twilightwanderer commented Oct 11, 2022

twilightwanderer commented Sep 22, 2022 •

edited

twilightwanderer commented Sep 22, 2022 •

edited