Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return jump optimizations and modularity #2520

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

Bokkiewokkie
Copy link
Contributor

About The Pull Request

Fixes #2487 and that you could spam-click the comms console during a return vote to destroy the crew's psyche.
Also adds the ability to save a custom system to return to in the map config, so we can add maps or game modes which don't always end there, also possible through overriding these variables on runtime.

Why It's Good For The Game

Fixes good
More ways to create events or do funny things are also good.

Testing Photographs and Procedure

Screenshots&Videos Worked on my machine

Changelog

🆑
fix: Fixed return vote spamming with the comms console
fix: Fixed forced return jumps not jumping while the ship was in transit
refactor: Refactored some starsystem code which determines the system to make a return jump to
admin: Added the ability for the return system to be changed on runtime
config: The return jump target system is now changeable in the map config
/:cl:

@Bokkiewokkie Bokkiewokkie merged commit 348046b into BeeStation:master Sep 1, 2023
8 checks passed
@Bokkiewokkie Bokkiewokkie deleted the outposting branch February 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Fix Mapping Refactor Starsystem Issues and pull requests related to star systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTL super spacing
1 participant