Return jump optimizations and modularity #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bokkiewokkie
added
Fix
Administration
Refactor
Mapping
Starsystem
Bokkiewokkie
commented
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #2487 and that you could spam-click the comms console during a return vote to destroy the crew's psyche.
Also adds the ability to save a custom system to return to in the map config, so we can add maps or game modes which don't always end there, also possible through overriding these variables on runtime.
Why It's Good For The Game
Fixes good
More ways to create events or do funny things are also good.
Testing Photographs and Procedure
Screenshots&Videos
Worked on my machineChangelog
馃啈
fix: Fixed return vote spamming with the comms console
fix: Fixed forced return jumps not jumping while the ship was in transit
refactor: Refactored some starsystem code which determines the system to make a return jump to
admin: Added the ability for the return system to be changed on runtime
config: The return jump target system is now changeable in the map config
/:cl: