-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for php 7.4 #1236
Add support for php 7.4 #1236
Conversation
.travis.yml
Outdated
before_install: | ||
- phpenv config-rm xdebug.ini | ||
- php: 7.4snapshot | ||
env: SYMFONY_VERSION='^3.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for these 2 jobs testing 7.4 against specific SF versions. A single job running PHP 7.4 is enough (and we only need a single job forcing specifc SF LTS versions)
.travis.yml
Outdated
@@ -26,9 +26,10 @@ matrix: | |||
env: SYMFONY_VERSION='^3.4' | |||
- php: 7.3 | |||
env: SYMFONY_VERSION='^4.2' | |||
|
|||
before_install: | |||
- phpenv config-rm xdebug.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be kept for versions having xdebug. Change it to phpenv config-rm xdebug.ini || true
to avoid making it fail when xdebug is not available.
Looks like Transliterator's dependecy is not ready for 7.4 |
@snapshotpl any chance to contribute there first then ? |
Waiting for v1.3 of behat/transliterator appear on packagist https://packagist.org/packages/behat/transliterator |
@snapshotpl The transliterator tag is released now on packagist |
(we don't need 'snapshot' now I think) |
One test in php 7.4 doesn't pass. @ciaranmcnulty can you help me to resolve this https://travis-ci.org/Behat/Behat/jobs/637319029#L316 ? |
Hm, something must have changed around error handling... |
@ciaranmcnulty @snapshotpl we really need to delete the offending test at https://github.com/snapshotpl/Behat/blob/ea89bd18f290a26c0c7fc0e8aa3205242bf7e5b8/features/junit_format.feature#L529-L587 . It's tagged only to run in PHP 5.3 and 5.4. The system by which these tags are used in Travis is a bit of a mess because:
I'll do a separate pull request cleaning up the whole fiasco at Line 40 in 7aa8161
The rest of your PHP looks great, thanks so much for doing this. |
@Sam-Burns nice catch! So I'm waiting for PR to clean this an then I will rebase your fix here |
90c1c79
to
ea89bd1
Compare
@Sam-Burns awesome. Now waiting for fixed builds. @ciaranmcnulty ? |
@ciaranmcnulty ready to merge! |
Thanks, Witold! 🎉 |
No description provided.