Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better CMake Support #10

Closed
uilianries opened this issue Nov 15, 2018 · 4 comments
Closed

Better CMake Support #10

uilianries opened this issue Nov 15, 2018 · 4 comments

Comments

@uilianries
Copy link
Contributor

Hi!

I have few questions again:

  • Is there any idea supporting shared library?
    I found add_library(behavior_tree_core STATIC ${BT_Source} ). The library is forced to be static ever.

  • Could fPIC be more relaxed?
    I found target_compile_options(behavior_tree_core PRIVATE "-fPIC"). However cmake provides POSITION_INDEPENDENT_CODE which is possible to be used as fPIC but as optional.

  • Is there any idea supporting install target?
    I didn't find intall section in your cmake file. It could help all customers.

  • Do you want export BehaviorTree using cmake config file?
    CMake provides helpers to exports all paths and libraries names in a single file.

  • Is BehaviorTree supported on Windows and Macos?
    I found set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -pthread -Werror=return-type -Wall -Wpedantic -Wattributes") that is related to Linux (clang, gcc)

As I have some experience with CMake, I would be happy helping this project updating your cmake as well. I could create a separated PR introducing all changes.

@facontidavide
Copy link
Collaborator

Hi,

let me answer in order:

  1. I Guess that there is no problem to remove STATIC

  2. I need to check that the generate plugins would still work as expected

  3. Yes, please check the open pull request. CMake: major refactoring. Added install command. #9

  4. I am not familiar with it, any help is welcome.

  5. I want to make it available for Windows too, I am just too busy to focus much on it. With a little work, it should be easy.

facontidavide pushed a commit that referenced this issue Nov 15, 2018
@facontidavide
Copy link
Collaborator

Please take a look at this branch... https://github.com/BehaviorTree/BehaviorTree.CPP/tree/cmake_fix
I have to think more about the installation.

facontidavide added a commit that referenced this issue Nov 16, 2018
* fix travis
* better installation with renamed directories
@facontidavide
Copy link
Collaborator

I just release changes that should solve most of the issues you mentioned, except number 4, where I need someone to send me some references about packaging with CMake.

@uilianries
Copy link
Contributor Author

Thanks for your answer! I will provide a PR with the number 4 (cmake export).

uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 16, 2018
- Add cmake export to generate BehaviorTreeConfig.cmake
- Install config cmake file
- Update C++11 by target property

Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 16, 2018
- Add cmake export to generate BehaviorTreeConfig.cmake
- Install config cmake file
- Update C++11 by target property

Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 17, 2018
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 17, 2018
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 17, 2018
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 17, 2018
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 17, 2018
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 17, 2018
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries added a commit to uilianries/BehaviorTree.CPP that referenced this issue Nov 17, 2018
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants