-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better CMake Support #10
Comments
Hi, let me answer in order:
|
Please take a look at this branch... https://github.com/BehaviorTree/BehaviorTree.CPP/tree/cmake_fix |
I just release changes that should solve most of the issues you mentioned, except number 4, where I need someone to send me some references about packaging with CMake. |
Thanks for your answer! I will provide a PR with the number 4 (cmake export). |
- Add cmake export to generate BehaviorTreeConfig.cmake - Install config cmake file - Update C++11 by target property Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Add cmake export to generate BehaviorTreeConfig.cmake - Install config cmake file - Update C++11 by target property Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Hi!
I have few questions again:
Is there any idea supporting shared library?
I found add_library(behavior_tree_core STATIC ${BT_Source} ). The library is forced to be static ever.
Could fPIC be more relaxed?
I found target_compile_options(behavior_tree_core PRIVATE "-fPIC"). However cmake provides POSITION_INDEPENDENT_CODE which is possible to be used as fPIC but as optional.
Is there any idea supporting install target?
I didn't find intall section in your cmake file. It could help all customers.
Do you want export BehaviorTree using cmake config file?
CMake provides helpers to exports all paths and libraries names in a single file.
Is BehaviorTree supported on Windows and Macos?
I found set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -pthread -Werror=return-type -Wall -Wpedantic -Wattributes") that is related to Linux (clang, gcc)
As I have some experience with CMake, I would be happy helping this project updating your cmake as well. I could create a separated PR introducing all changes.
The text was updated successfully, but these errors were encountered: