CMake: major refactoring. Added install command. #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request includes a re-factoring of the CMake. A install command has been added to be able to install the project as a standalone library (or within catkin as well) so users can just
find_package
it. The standalone installation supports version numbering. External dependencies (threads, dl and [zmq]) and headers paths are included in the cmake target, so it can be imported and used in external projects easily:find_package(behavior_tree_core 1.0 REQUIRED)
target_link_libraries(Foo behavior_tree_core)
I had to change the minimum required CMake version up to 3.1 to use some features. Tell me if this is an issue.
Also, to be able to use it as a catkin module I had to include the 3rdparty folder in the
catkin_package
, but there was a comment explicitly discouraging it. I may have to look deeper into this.I plan on adding deb packages generation later down the road if you think it would be a good addition.