Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken catkin build and debian package 3.8.0 for ROS noetic #478

Closed
rcp1-beg opened this issue Nov 24, 2022 · 3 comments
Closed

Broken catkin build and debian package 3.8.0 for ROS noetic #478

rcp1-beg opened this issue Nov 24, 2022 · 3 comments
Assignees

Comments

@rcp1-beg
Copy link

rcp1-beg commented Nov 24, 2022

Hi,

the released version 3.8.0 for ROS 1 noetic (20.04) broke the catkin build by providing two cmake files with the same name:

lib/cmake/behaviortree_cpp_v3/behaviortree_cpp_v3Config.cmake <-- Generated by cmake configure_package_config_file
share/behaviortree_cpp_v3/cmake/behaviortree_cpp_v3Config.cmake <-- Generated by catkin

Catkin will find for dependent packages the first one, detect that behaviortree_cpp_v3 is not a proper catkin package and does not provide the standardized package variables. Thus, one needs to manually link BT::behaviortree_cpp_v3 with this release.

The problem was introduced with #379 as far as I can tell. One could wrap the manual configure_package_config_file in the CMakeLists.txt with if(NOT catkin_FOUND) as simplistic fix.

Thanks for looking into it!

@rcp1-beg rcp1-beg changed the title Broken catkin build and debian package for ROS noetic Broken catkin build and debian package 3.8.0 for ROS noetic Nov 24, 2022
@facontidavide
Copy link
Collaborator

facontidavide commented Nov 24, 2022

Just to be sure, what is your level of confidence on the solution that you mention will work and it will not break the behavior for others?

@facontidavide facontidavide self-assigned this Nov 24, 2022
facontidavide added a commit that referenced this issue Nov 27, 2022
@facontidavide
Copy link
Collaborator

Should be fixed. I am bloom-ing soon

@rcp1-beg
Copy link
Author

rcp1-beg commented Dec 5, 2022

Thank you very much for the fix. Sorry that I did not answer your question, I was on vacation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants