Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit export configuration #379

Merged
merged 1 commit into from
May 21, 2022

Conversation

artivis
Copy link
Contributor

@artivis artivis commented May 14, 2022

While building ROS 2 from source together with Nav2 and BT I've encountered a couple issues with BT.

  • First the Config.cmake file exported was named BehaviorTreeV3Config.cmake whereas, the project being named behaviortree_cpp_v3, one would expect the file to be behaviortree_cpp_v3Config.cmake.
  • Second, for some reason I would never enter the if(ament_cmake_FOUND) conditional block, thus the behaviortree_cpp_v3_TARGETS would never be automatically exported by ament and thus never found when BT is included in another project; ament_target_dependencies depends on it to properly set up the interfaces.

This PR adresses both issues by revisiting the project export configuration following the tutorial on CMake website.

Marking as draft since I've only tested my use case and this may break others.

@facontidavide
Copy link
Collaborator

Look good to me, but did you check if the NON ROS compilation still work?

@facontidavide facontidavide marked this pull request as ready for review May 21, 2022 18:46
@facontidavide facontidavide merged commit e11d3ef into BehaviorTree:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants