Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): Banner positions #1346

Merged
merged 2 commits into from Dec 30, 2023
Merged

Conversation

XangelMusic
Copy link
Collaborator

Created a new drop-down list for Banner Position.

Notification has its own group box in Settings.

Copy link
Owner

@Belphemur Belphemur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !
Only one small change requested and it's ready to merge :)

SoundSwitch/Framework/Banner/BannerForm.cs Outdated Show resolved Hide resolved
Co-authored-by: Antoine Aflalo <Belphemur@users.noreply.github.com>
@Belphemur Belphemur merged commit 40892fe into Belphemur:dev Dec 30, 2023
9 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
## [6.9.0-beta.1](v6.8.1...v6.9.0-beta.1) (2024-04-03)

### Enhancements

* **notification:** Added Top Center/Bottom Center to Banner Positions ([#1347](#1347)) ([1566fc9](1566fc9))
* **notification:** Merged Custom Sound Notification into Sound Notification ([#1352](#1352)) ([a163a09](a163a09))
* **volume:** Keep volume includes both playback and recording devices ([03d1aa8](03d1aa8))

### Languages

* **Croatian:** Translated Settings using Weblate ([2503908](2503908))
* **Croatian:** Translated Settings using Weblate ([9dcc946](9dcc946))
* **Croatian:** Translated Settings using Weblate ([3ed5521](3ed5521))
* **French:** Translated Settings using Weblate ([3d48b72](3d48b72))
* **German:** Translated Settings using Weblate ([9d414d2](9d414d2))
* **German:** Translated Settings using Weblate ([c3598bf](c3598bf))
* **Hebrew:** Translated Settings using Weblate ([00a65a5](00a65a5))
* **Hungarian:** Translated Settings using Weblate ([97faf79](97faf79))
* **Hungarian:** Translated Tray Icon using Weblate ([a191a49](a191a49))
* **Hungarian:** Translated Update Download using Weblate ([e85e988](e85e988))
* **Portuguese:** Translated Settings using Weblate ([cccdf71](cccdf71))
* **Portuguese:** Translated Settings using Weblate ([b53b37b](b53b37b))
* **Russian:** Translated Settings using Weblate ([1c93c71](1c93c71))
* **Slovenian:** Translated About using Weblate ([15e1747](15e1747))
* **Slovenian:** Translated Settings using Weblate ([a0feb07](a0feb07))
* **Spanish:** Translated Settings using Weblate ([b16f033](b16f033))
* **Spanish:** Translated Settings using Weblate ([9dc33bb](9dc33bb))
* **Spanish:** Translated Settings using Weblate ([7569270](7569270))
* **Swedish:** Translated Settings using Weblate ([1bb6efb](1bb6efb))
* **Swedish:** Translated Settings using Weblate ([6b3a6e7](6b3a6e7))
* **Swedish:** Translated Settings using Weblate ([a65951a](a65951a))
* **Ukrainian:** Translated Settings using Weblate ([c3ed595](c3ed595))
* **Ukrainian:** Translated Tray Icon using Weblate ([48b11b7](48b11b7))

### Bug Fixes

* comparing devices event, needs to also compare the id ([4851b43](4851b43))
* getting all device that have name ([d695d2d](d695d2d))
* possible issue where device not removed from the list when renamed ([8ed0f14](8ed0f14))
* **volume:** Volume levels across dual-audio channels now kept for keep volume option ([#1371](#1371)) ([7121ecb](7121ecb))

### Features

* **autoadd:** remove the auto add feature ([dd39379](dd39379))
* make audioswitcher able to provide list of devices ([0d31968](0d31968))
* **notification:** Banner positions ([#1346](#1346)) ([40892fe](40892fe)), closes [#242](#242) [#1176](#1176)
Copy link
Contributor

github-actions bot commented Apr 3, 2024

🎉 This PR is included in version 6.9.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
## [6.9.0-beta.1](v6.8.1...v6.9.0-beta.1) (2024-04-03)

### Enhancements

* **notification:** Added Top Center/Bottom Center to Banner Positions ([#1347](#1347)) ([1566fc9](1566fc9))
* **notification:** Merged Custom Sound Notification into Sound Notification ([#1352](#1352)) ([a163a09](a163a09))
* **volume:** Keep volume includes both playback and recording devices ([03d1aa8](03d1aa8))

### Languages

* **Croatian:** Translated Settings using Weblate ([2503908](2503908))
* **Croatian:** Translated Settings using Weblate ([9dcc946](9dcc946))
* **Croatian:** Translated Settings using Weblate ([3ed5521](3ed5521))
* **French:** Translated Settings using Weblate ([3d48b72](3d48b72))
* **German:** Translated Settings using Weblate ([9d414d2](9d414d2))
* **German:** Translated Settings using Weblate ([c3598bf](c3598bf))
* **Hebrew:** Translated Settings using Weblate ([00a65a5](00a65a5))
* **Hungarian:** Translated Settings using Weblate ([97faf79](97faf79))
* **Hungarian:** Translated Tray Icon using Weblate ([a191a49](a191a49))
* **Hungarian:** Translated Update Download using Weblate ([e85e988](e85e988))
* **Portuguese:** Translated Settings using Weblate ([cccdf71](cccdf71))
* **Portuguese:** Translated Settings using Weblate ([b53b37b](b53b37b))
* **Russian:** Translated Settings using Weblate ([1c93c71](1c93c71))
* **Slovenian:** Translated About using Weblate ([15e1747](15e1747))
* **Slovenian:** Translated Settings using Weblate ([a0feb07](a0feb07))
* **Spanish:** Translated Settings using Weblate ([b16f033](b16f033))
* **Spanish:** Translated Settings using Weblate ([9dc33bb](9dc33bb))
* **Spanish:** Translated Settings using Weblate ([7569270](7569270))
* **Swedish:** Translated Settings using Weblate ([1bb6efb](1bb6efb))
* **Swedish:** Translated Settings using Weblate ([6b3a6e7](6b3a6e7))
* **Swedish:** Translated Settings using Weblate ([a65951a](a65951a))
* **Ukrainian:** Translated Settings using Weblate ([c3ed595](c3ed595))
* **Ukrainian:** Translated Tray Icon using Weblate ([48b11b7](48b11b7))

### Bug Fixes

* comparing devices event, needs to also compare the id ([4851b43](4851b43))
* getting all device that have name ([d695d2d](d695d2d))
* possible issue where device not removed from the list when renamed ([8ed0f14](8ed0f14))
* **volume:** Volume levels across dual-audio channels now kept for keep volume option ([#1371](#1371)) ([7121ecb](7121ecb))

### Features

* **autoadd:** remove the auto add feature ([dd39379](dd39379))
* make audioswitcher able to provide list of devices ([0d31968](0d31968))
* **notification:** Banner positions ([#1346](#1346)) ([40892fe](40892fe)), closes [#242](#242) [#1176](#1176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants