Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow recommendations of codex32 authors for deterministic codex32 share set generation #72

Closed
BenWestgate opened this issue Jul 30, 2023 · 1 comment
Closed

Follow recommendations of codex32 authors for deterministic codex32 share set generation #72

BenWestgate opened this issue Jul 30, 2023 · 1 comment
Assignees
@BenWestgate
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right performance priority: low Issues raised by only myself question Further information is requested

Comments

@BenWestgate
Copy link
Owner

BlockstreamResearch/codex32#57

This will improve the time it takes to display the codex32 shares and make the backup easier to audit by hand, if anyone ever tries.

Then update the code that checks for the correct passphrase entry during recovery to compare entered share payloads against the ones that derive from the seed for perfect passphrase error detection that does not depend on the identifier which may change or be set custom. This removes the one in a million risk of the wrong passphrase being accepted and the user recovering the wrong wallet!
@BenWestgate BenWestgate self-assigned this Jul 30, 2023
@BenWestgate BenWestgate added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed question Further information is requested priority: low Issues raised by only myself performance labels Jul 30, 2023
@BenWestgate BenWestgate mentioned this issue Aug 25, 2023
Open
@BenWestgate BenWestgate added the invalid This doesn't seem right label Sep 9, 2023
@BenWestgate
Copy link
Owner Author

Not planned now, because I became the author for codex32 deterministic share set generation.

Will reopen when the codex32 authors review my PR and complete a wallet codex32 backup generation document

@BenWestgate BenWestgate closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenWestgate BenWestgate

Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right performance priority: low Issues raised by only myself question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenWestgate