Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder: Visited island members list #1246

Closed
Poslovitch opened this issue Mar 26, 2020 · 5 comments
Closed

Placeholder: Visited island members list #1246

Poslovitch opened this issue Mar 26, 2020 · 5 comments
Assignees
@Poslovitch
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone
1.13.0

Comments

@Poslovitch
Copy link
Member

Description

Based on #1243, we should add a similar placeholder, this time for "visited island", i.e. the island the player is standing on.

Placeholder: [gamemode]_visited_island_members_list
@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Status: Pending Waiting for a developer to start working on this issue. labels Mar 26, 2020
@Poslovitch Poslovitch added this to the 1.13.0 milestone Mar 26, 2020
@BONNe
Copy link
Member

BONNe commented Mar 26, 2020

Probably better would be for each member rank :D

An owner can be just one, but sub owners? Trusted and coop, as well as banned.

@HardMCore
Copy link

HardMCore commented Mar 26, 2020 •
edited
Loading

@BONNe other player's ranks can be simply checked with other placeholders, so I guess there is no need to make one another placeholder for it.
EDIT: sorry, it's not possible, my mistake

@BONNe
Copy link
Member

BONNe commented Mar 26, 2020

There is a RANK placeholder, but it returns rank for each player.
But not via versa, so I still think, implementing ability to get players from by ranks would be useful.

@HardMCore
Copy link

Oh, so isn't it just about getting player's name through [gamemode]_island_members_list and then just checking player's [gamemode]_rank?

@Poslovitch
Copy link
Member Author

Please file another Placeholder request for that. That's not related to this current request.

@Poslovitch Poslovitch added Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Mar 30, 2020
@Poslovitch Poslovitch self-assigned this Mar 30, 2020
Poslovitch added a commit that referenced this issue Mar 30, 2020
@Poslovitch
Added %[gamemode]_visited_island_members_list% placeholder
7966146 
Implements #1246
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poslovitch Poslovitch

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.13.0
Development

No branches or pull requests
3 participants
@BONNe @Poslovitch @HardMCore