Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/bsb settings for kgenerators #1915

Closed
Envqu opened this issue Jan 8, 2022 · 7 comments
Closed

/bsb settings for kgenerators #1915

Envqu opened this issue Jan 8, 2022 · 7 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug

Comments

@Envqu
Copy link

Envqu commented Jan 8, 2022

Expected behavior

I want to change flag with command for kgenerators but I cant.

Observed/Actual behavior

I can see Generator flag in gui but there is no command.
image
image

Steps/models to reproduce

/bsb settings Nick KGENERATORS_USE_FLAG Lider

BentoBox version

image

Plugin list

No response

Other

No response

@tastybento
Copy link
Member

@BONNe Do you understand this? I don't know what KGenerators is. The addon list doesn't show a generator addon so I'm confused.

@BONNe
Copy link
Member

BONNe commented Jan 8, 2022

I assume that flag is added by plugin.

About the issue, could it be that flags provided outside core are not populated in the maps:

PROTECTION_FLAG_NAMES = getPlugin().getFlagsManager().getFlags().stream()
.filter(f -> f.getType().equals(Type.PROTECTION))
.filter(f -> f.getGameModes().isEmpty() || gameMode == null || f.getGameModes().contains(gameMode))
.map(Flag::getID)
.collect(Collectors.toList());
SETTING_FLAG_NAMES = getPlugin().getFlagsManager().getFlags().stream()
.filter(f -> f.getType().equals(Type.SETTING))
.filter(f -> f.getGameModes().isEmpty() || gameMode == null || f.getGameModes().contains(gameMode))
.map(Flag::getID)
.collect(Collectors.toList());
WORLD_SETTING_FLAG_NAMES = getPlugin().getFlagsManager().getFlags().stream()
.filter(f -> f.getType().equals(Type.WORLD_SETTING))
.filter(f -> f.getGameModes().isEmpty() || gameMode == null || f.getGameModes().contains(gameMode))
.map(Flag::getID)

@Envqu
Copy link
Author

Envqu commented Jan 9, 2022

Well, only creator of KGenerators plugin can fix this?
https://www.spigotmc.org/resources/kgenerators-custom-block-generator-stone-generator-1-8-1-17.79246/

@tastybento tastybento self-assigned this Jan 10, 2022
tastybento added a commit that referenced this issue Jan 10, 2022
@tastybento
Copy link
Member

No, it's a bug on our side. I think I've fixed it - try the latest CI build. https://ci.codemc.io/job/BentoBoxWorld/job/BentoBox/.

@tastybento tastybento added the Status: Done This issue has been completed or answered. This pull request has been merged. label Jan 10, 2022
@Envqu
Copy link
Author

Envqu commented Jan 13, 2022

BentoBox 1.20 not supporting 1.16.5 :/

@tastybento
Copy link
Member

@Envqu
Copy link
Author

Envqu commented Jan 17, 2022

Thanks, its working now ;)

@Envqu Envqu closed this as completed Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants