Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unprotected area protection settings #384

Closed
TheWranger opened this issue Dec 15, 2018 · 6 comments
Closed

Unprotected area protection settings #384

TheWranger opened this issue Dec 15, 2018 · 6 comments
Assignees
@tastybento
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Status: Duplicate Related to an existing issue. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone
1.6.0

Comments

@TheWranger
Copy link

TheWranger commented Dec 15, 2018 •
edited
Loading

Is your feature request related to a problem? Please describe.
There's currently no way to modify the protection settings of areas that are not considered part of a player's island. This is very limiting for servers that might want to change these things, for example; I want to run a server where people can freely break and destroy outside of their protected islands but not within the protected space of other islands.

Describe the solution you'd like
An additional category in the island settings GUI where we can modify the protection settings of unprotected areas. Should maybe also be changeable by config.

Describe alternatives you've considered
Haven't thought of any other alternatives.
@Poslovitch Poslovitch added the Type: Enhancement Improvement or modification which is usually a new feature. label Dec 15, 2018
@tastybento
Copy link
Member

Should be possible. It's just a matter of using the Flag.setDefaultSetting(boolean) method.

Actually, it'll be good to have a default setting tab anyway.

@Poslovitch
Copy link
Member

Yeah, I agree. Though it's currently not how the Settings Panel is done right now. Categories are basically the "flag type".

@tastybento
Copy link
Member

Good point. Hmm, special handling, joy!

@Poslovitch Poslovitch added the Status: Pending Waiting for a developer to start working on this issue. label Jun 5, 2019
@Poslovitch Poslovitch added this to the 1.6.0 milestone Jun 5, 2019
@Poslovitch Poslovitch added Status: Under investigation Investigating the interest and the feasability of the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Jul 5, 2019
@tastybento tastybento added the Status: Duplicate Related to an existing issue. label Jul 14, 2019
@tastybento
Copy link
Member

Done in #840 in terms of config.yml. Not done in terms of another GUI.

@tastybento
Copy link
Member

I did a lot of work on Flags today (hours) and abstracted out the GUI from the Flag types. I'll do a PR tomorrow.

@tastybento
Copy link
Member

Just a follow up - there's more to do here. The PR will come but it's being worked on!

@tastybento tastybento self-assigned this Jul 29, 2019
@tastybento tastybento added Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Jul 29, 2019
tastybento added a commit that referenced this issue Jul 29, 2019
@tastybento
Adds default world protection settings GUI
aea8197 
This switches the settings panel to use the new TabbedPanel API.

#384
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Jul 30, 2019
tastybento added a commit that referenced this issue Aug 3, 2019
@tastybento
Tab panels (#857)
13ee55a 
TabbedPanel extends Panel so that when an icon is
clicked, the context can be gathered by the click listener via the
getActiveTab method. In this case, the CycleClick and IslandToggleClick
classes cast the tab to the SettingsTab so they can retrieve the island
that the panel is referring too. This is required in the case where an
admin is setting a user's island settings. Previously the context of a
panel was only every about the user who opened the panel.

* Adds a tabbed panel API

* Added permission for tab

* Adds default world protection settings GUI

This switches the settings panel to use the new TabbedPanel API.

#384

* Adds admin command to change a player's settings.

Requires addon to add the admin settings command.

#59

* Locale for AdminSettingsCommand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Status: Duplicate Related to an existing issue. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@tastybento @Poslovitch @TheWranger