Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to change POM causes problems with SNAPSHOTS #603

Closed
tastybento opened this issue Mar 9, 2019 · 3 comments
Closed

PR to change POM causes problems with SNAPSHOTS #603

tastybento opened this issue Mar 9, 2019 · 3 comments
Assignees

Comments

@tastybento
Copy link
Member

Description

Describe the bug

With PR #596 a change was made to add build numbers to SNAPSHOTS. I think this will need to be adjusted because having a build number of SNAPSHOTS is causing problems for addon dependencies. I already cannot get the latest version build of BentoBox with BSkyBlock and quoting the build number in Addon dependencies is not good. (Also it does not work).

Here's a quote from StackExchange on this:

Maven provides the SNAPSHOT keyword to signify a volatile project in active development. So if you reference a project with a SNAPSHOT dependency version, Maven will automatically check for updates and keep your dependencies in sync.
If you then add a build number to the end of that version, you will have to manually update the dependencies, so you lose any benefit of having the SNAPSHOT suffix.

Expected behavior

Addons can just use the SNAPSHOT or release version in dependency.

@tastybento
Copy link
Member Author

@BONNe @Poslovitch I'm going to remove the Build number feature from the POM for now.

@tastybento
Copy link
Member Author

BSkyBlock now compiles correctly.

@sgdc3
Copy link
Contributor

sgdc3 commented Mar 9, 2019

the build number should NEVER be used in the pom version, you can add it to the final jar name if you want

@BentoBoxWorld BentoBoxWorld locked as resolved and limited conversation to collaborators Mar 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants