Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BentoBox pom. #596

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Improve BentoBox pom. #596

merged 2 commits into from
Mar 8, 2019

Conversation

BONNe
Copy link
Member

@BONNe BONNe commented Mar 5, 2019

Add 3 new profiles:

  • local profile is activated by default and it will add -SNAPSHOT at the end of version.
  • develop profile is activated when exist BUILD_NUMBER environment variable and it will add -SNAPSHOT #BUILD+_NUMBER at the end of version
  • master profile is activated when exists GIT_BRANCH environment variable with value origin/master and it will not add anything to version.

Also, move most of dependencies versions to properties section.

With these changes, it will be easier to process next release. Only change build.version in properties section.

If you run maven package or install from IDE or console, it will add -SNAPSHOT at the end (unless you have local Jenkins server). [bentobox-1.4.0-SNAPSHOT.jar]
In Jenkins server builds from develop branch will look like bentobox-1.4.0-SNAPSHOT #21.jar.
In Jenkins server builds from master branch will look like bentobox-1.4.0.jar.

Add 3 new profiles:
- local profile is activated by default and it will add -SNAPSHOT at the end of version.
- develop profile is activated when exist BUILD_NUMBER environment variable and it will add -SNAPSHOT #BUILD+_NUMBER at the end of version
- master profile is activated when exists GIT_BRANCH environmnent variable with value origin/master and it will not add anything to version.

Also, move most of dependencies versions to properties section.
@Poslovitch Poslovitch self-requested a review March 7, 2019 06:36
@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Priority: Low Status: Need review Waiting for a review to be made on this Pull Request labels Mar 7, 2019
@tastybento tastybento self-requested a review March 8, 2019 02:55
Copy link
Member

@tastybento tastybento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks all good.

@Poslovitch Poslovitch added Status: Accepted and removed Status: Need review Waiting for a review to be made on this Pull Request labels Mar 8, 2019
@Poslovitch Poslovitch added this to the 1.4.0 milestone Mar 8, 2019
@Poslovitch Poslovitch merged commit e3fbeb1 into BentoBoxWorld:develop Mar 8, 2019
@BONNe BONNe deleted the pom branch March 9, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants