Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MVdWPlaceholderAPI #651

Closed
MorkaZ opened this issue May 1, 2019 · 8 comments
Closed

Add support for MVdWPlaceholderAPI #651

MorkaZ opened this issue May 1, 2019 · 8 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone

Comments

@MorkaZ
Copy link

MorkaZ commented May 1, 2019

Please, add support for MVdWPlaceholderAPI.
It is very simple to do and gives much more possibilities for minecraft server creators (for example it allows to add level of island to feather board).

@BONNe
Copy link
Member

BONNe commented May 1, 2019

Sorry, it is too complicated for us.
You can do it yourself.
Here a link in wiki how to implement any API support with us small codding as possible:
https://github.com/BentoBoxWorld/Level/wiki/Placeholders

@tastybento
Copy link
Member

I'm confused - the placeholders already support PAPI. Is this a different API?

@Poslovitch
Copy link
Member

BentoBox already supports PlaceholderAPI. The appropriate answer to this ticket should be RT(F)M, as this is clearly a lack of reading the documentation.

Closing.

@Poslovitch
Copy link
Member

Nevermind, the ticket is clearly confusing. He's talking of MVdWPlaceholderAPI...

Moving to BentoBox and reopening.

@Poslovitch Poslovitch reopened this May 1, 2019
@Poslovitch Poslovitch transferred this issue from BentoBoxWorld/Level May 1, 2019
@Poslovitch Poslovitch added Status: Accepted Type: Enhancement Improvement or modification which is usually a new feature. Status: Under investigation Investigating the interest and the feasability of the issue. and removed Status: Accepted labels May 1, 2019
@Poslovitch Poslovitch self-assigned this May 1, 2019
@Poslovitch Poslovitch changed the title Add support for PlaceholderAPI Add support for MVdWPlaceholderAPI May 1, 2019
@Poslovitch
Copy link
Member

I had a tough time trying to do that back when I implemented placeholders support. In the meantime, you can install PlaceholderAPI and use the MVdW's format to get the PAPI's placeholders (search for it if you don't know how).

@MorkaZ
Copy link
Author

MorkaZ commented May 2, 2019

I have found that it is possible to get PAPI's plceholder in MVdW's just by adding "placeholderapi_" but..

{placeholderapi_bskyblock-island-level}

This does not work :c

@Poslovitch
Copy link
Member

@MorkaZ Yes, that is how it works. However I'm pretty sure that if I don't add support directly for MVdWPAPI, I'll keep having feature requests about it.
And It's placeholderapi_Level_bskyblock-island-level currently (yeah I know, it's verbose).

@Poslovitch
Copy link
Member

I somehow managed to implement the hook for MVdWPlaceholderAPI, although:

  1. It has way fewer features than PlaceholderAPI does.
  2. It's only used in MVdW's own plugins.
  3. The artifacts from the official repository cannot be retrieved because they use an illegal artifact of Spigot which has lately been removed.
  4. It does not provide support for a few features we need, especially when it comes to support reloading.

As such, I feel completely swindled and I will only provide extremely limited support, as of today, for hooks that are being made against premium or premium-related plugins, if not at all.

@Poslovitch Poslovitch modified the milestones: 1.6.0, 1.5.0 May 31, 2019
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants