Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable commands to run after new island is made #704

Closed
tastybento opened this issue May 26, 2019 · 5 comments
Closed

Enable commands to run after new island is made #704

tastybento opened this issue May 26, 2019 · 5 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone

Comments

@tastybento
Copy link
Member

Description

Describe the solution you'd like us to implement.

ASkyBlock had a way to run commands after an island was made so admins could kit players or do other things. It'd be good to have that.

Describe alternatives you've considered.

A global command set to run in a config file. Adding commands to Blueprint Bundles.

Additional context

@tastybento tastybento added Type: Enhancement Improvement or modification which is usually a new feature. Status: In progress Working on the issue. labels May 26, 2019
@tastybento tastybento self-assigned this May 26, 2019
@tastybento tastybento added this to the 1.5.0 milestone May 26, 2019
@tastybento
Copy link
Member Author

After reviewing this more, I think the best place for these are actually in the add-on's config file, e.g. BSkyBlock's. Here's the config from ASkyBlock:

   #Commands to run when the player resets their island (uncomment and customize)
   # [player] is the player name of who is reseting
   # If the command is proceeded by [SELF] the command will be run as that player
   # E.g., - "[SELF] kit tools"
   resetcommands:
   #- "kit tools [player]"
   #- "some other command"

   # Commands to execute when player leaves a team, either by leaving or being kicked
   # Commands will execute even if the player is offline, so may cause errors in
   # the console if the commands doesn't make sense
   leavecommands:
   #- "kit tools [player]"
   #- "some other command"

   # Commands to execute when a player starts a new island for the first time - NOT a reset
   startcommands:
   #- "asadmin lock [player]"
   #- "[SELF] balance"
   #- "some other command"

   # Commands to execute when a player joins a new team island (does /island accept)
   teamstartcommands:
   #- "[SELF] balance"
   #- "some other command"

@tastybento tastybento removed the Status: In progress Working on the issue. label May 26, 2019
@tastybento tastybento removed this from the 1.5.0 milestone May 26, 2019
@Poslovitch Poslovitch added the Status: In progress Working on the issue. label May 27, 2019
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. and removed Status: In progress Working on the issue. labels Jun 8, 2019
@wellnesscookie
Copy link
Contributor

wellnesscookie commented Jun 8, 2019

@tastybento

If the leave part also includes a user being force-kicked (not by a player) by an operator via /bsbadmin kick, then - yes - that would be the cross-refferenced feature request.

Not sure about what happens on /bsbadmin delete? I would like to have it there too, but let me know what you think.

Did not spot that it was duplicate. Sorry!

@tastybento
Copy link
Member Author

Admin actions will not result in the commands being run. This is to make sure that admins can do and redo various actions with known consequences.

@mrfloris
Copy link

mrfloris commented Aug 9, 2019

We use CMI for example, a premium plugin that's like EssentialsX. It has loads of features from particles, to sounds, and i dunno what. It is super helpful.

We would love to use this so we can tell the system if someone creates an island that we first save their inventory in the world they're in, log to the system, they've created an island, do a title msg like success, with a ding sound, and add a slight delay and cooldown - before finally (second later) teleport them to their island.

We basically use custom command /skyblock to handle this, and /skyblock are like /island

If there's like
bskyblock-commands-on-island-creation:

  • this
  • that
  • the other

That would be rather fantastic. It helps make the plugin very dynamic, flexible, and easy to customize using existing commands, cmi also lets us run commands as a console, fake op, or regular player. So less hassle with certain permissions.

@Poslovitch Poslovitch modified the milestones: 1.7.0, 1.8.0 Sep 8, 2019
@Poslovitch Poslovitch assigned Poslovitch and unassigned tastybento Sep 28, 2019
@Poslovitch Poslovitch added Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Sep 28, 2019
Poslovitch added a commit that referenced this issue Sep 28, 2019
…ion/leave

Implements #704

Gamemode addons will need to be updated to use the new WorldSettings, which have been properly documented so it should be easy to write down comments about them.
@Poslovitch
Copy link
Member

Done.

@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants