Fly is getting disabled on Portal usage ( Nether/End )

[AmazedMender16]

Description

Describe the bug

Fly is getting disabled when going through a portal. ( end/nether )
This does not happen when using the the tp command

Steps to reproduce the behavior

Turn on fly ( EssentialsX ) and go through a portal.

Expected behavior

Fly should stay enabled like with askyblock

Environment

Server

• OS: Ubuntu Server 18.04
• Java version: 1.8.0_212

BentoBox setup

BentoBox and Addons

Running - SPIGOT 1.14.2.
BentoBox version - 1.5.3
Loaded Game Worlds:
- world (Skyblock): Overworld, Nether, End
Loaded Addons:
Biomes - 1.5.2.1-SNAPSHOT-b119
BSkyBlock - 1.5.3-SNAPSHOT
Challenges - 0.8.0-SNAPSHOT-#275
Level - 1.5.1-SNAPSHOT
Limits - 0.2.0-SNAPSHOT
WelcomeWarps - 1.5.0

Configuration

• Database: MYSQL

Additional context

[Typheonn]

I have the same problems with the latest version.

[tastybento]

@Poslovitch Any chance you could look at this?

[Poslovitch]

@tastybento I'll do.

[Poslovitch]

I confirmed the bug is occuring. I even got killed by that freaky Enderman! 🙁

[Poslovitch]

I think this is due to the brief gamemode switch. Upon teleporting, the player is set to the SPECTATOR gamemode so that he doesn't get killed if the world loads too slowly, and it then gets reset to the gamemode he was. This change causes Essentials to disable the fly mode.

[AmazedMender16]

Anything BentoBox can do to re-enable it if it was on?

[Poslovitch]

Okay, I think I've got my "culprit".
The admin command works fine, because it tells the SST (safe spot teleport) builder to not override the player's gamemode. Thus, Essentials does not remove the fly mode.

BentoBox/src/main/java/world/bentobox/bentobox/api/commands/admin/AdminTeleportCommand.java

Lines 58 to 64 in dffabd4

	// Teleport
	new SafeSpotTeleport.Builder(getPlugin())
	.entity(user.getPlayer())
	.location(warpSpot)
	.failureMessage(failureMessage)
	.overrideGamemode(false)
	.build();

The fix would be to tell the SST Builder the same thing in the PortalTeleportationListener... But if we'd do that there, we should just get rid of the SPECTATOR gamemode in our teleportation process once and for all: admins are not the only one who could be in fly mode. Lots of P2W Skyblock servers sell the fly as a perk.
The SPECTATOR gamemode thing sounds like it has way more downsides than advantages. What do you think @tastybento ?

[Poslovitch]

Anything BentoBox can do to re-enable it if it was on?

The other way around could be to run /fly. But that's not a nice solution as it can also cause its own issues.

[tastybento]

@Poslovitch I'm fine with removing spectator mode. The original aim was to place the player into a "safe" state while their island was being deleted and not fall to their death. Subsequently, we now only delete their island after the island is pasted and so they are now pretty safe.

[Poslovitch]

Okay, removing the SPECTATOR thing fixes everything.