Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to explicitly define asynchronous PremadeEvent #763

Merged
merged 3 commits into from
Jun 14, 2019
Merged

Added ability to explicitly define asynchronous PremadeEvent #763

merged 3 commits into from
Jun 14, 2019

Conversation

BONNe
Copy link
Member

@BONNe BONNe commented Jun 14, 2019

BentoBox PreMade event does not allow to define async events.
This will allow to define them.

@Poslovitch Poslovitch added Status: Need review Waiting for a review to be made on this Pull Request Type: Enhancement Improvement or modification which is usually a new feature. labels Jun 14, 2019
Poslovitch
Poslovitch approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good.

@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Need review Waiting for a review to be made on this Pull Request labels Jun 14, 2019
@Poslovitch Poslovitch added this to the 1.5.2 milestone Jun 14, 2019
@Poslovitch Poslovitch changed the title Add ability to define asynchronous event Added ability to explicitly define asynchronous PremadeEvent Jun 14, 2019
@Poslovitch Poslovitch merged commit d1e9188 into BentoBoxWorld:develop Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poslovitch Poslovitch Poslovitch approved these changes

Assignees
No one assigned
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@BONNe @Poslovitch