Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rainbow parens and paredit do not always agree about the structure #561

Closed
PEZ opened this issue Feb 17, 2020 · 0 comments
Closed

Rainbow parens and paredit do not always agree about the structure #561

PEZ opened this issue Feb 17, 2020 · 0 comments
Labels
highlight Syntax highlighting, rainbow parens, such things paredit Paredit and structural editing parsing

Comments

@PEZ
Copy link
Collaborator

PEZ commented Feb 17, 2020

Since Paredit uses a different parser than Highlight does, they sometimes disagree about the document structure.

This is mainly for when list openings have ”modifiers” that Paredit treats as part of the opening bracket, but Highlight doesn't. But it is generally a better situation to have both modules always agree about the structure.
@PEZ PEZ added paredit Paredit and structural editing parsing highlight Syntax highlighting, rainbow parens, such things labels Feb 17, 2020
@PEZ PEZ mentioned this issue Feb 18, 2020
Merged
20 tasks
@PEZ PEZ closed this as completed in dd0d8d3 Feb 23, 2020
PEZ added a commit that referenced this issue Mar 6, 2020
@PEZ
Use Token Cursor for rainbow parens (WIP)
a9f022e 
Fixes #561

This is a tad slower than the regex method was.
But there are probably performance gains to harvest.
And we should use the same parser as paedit uses anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
highlight Syntax highlighting, rainbow parens, such things paredit Paredit and structural editing parsing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PEZ