Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add pretty print mode #344

Merged
merged 14 commits into from
Sep 28, 2019
Merged

WIP - Add pretty print mode #344

merged 14 commits into from
Sep 28, 2019

Conversation

bpringe
Copy link
Member

@bpringe bpringe commented Sep 25, 2019

This pull request:

Resolves #327.

Introduces the following change(s):

  • Adds pretty print setting and defaults it to true - to pretty print by default
  • Makes all evaluations pretty print when pretty print setting is true, else no evaluations are pretty printed
  • Adds a toggle in the status bar to easily toggle pretty print
  • Removes all pretty print commands in favor of this setting/toggle

I have:

  • Read How to Contribute.
  • Made sure I am directing this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I am changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Referenced the issue I am fixing/addressing.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Updated the [Unrleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.

Ping: @PEZ, @kstehn

@bpringe
Copy link
Member Author

bpringe commented Sep 25, 2019

Still currently a WIP, as the title says. I just wanted to branch off of dev on my fork and reference the issue.

@bpringe
Copy link
Member Author

bpringe commented Sep 28, 2019

@PEZ @kstehn This PR is now complete. I tested the vsix (built locally, I couldn't find how to access the one built by Circle CI).

@PEZ PEZ merged commit b7f30b9 into BetterThanTomorrow:dev Sep 28, 2019
@PEZ
Copy link
Collaborator

PEZ commented Sep 28, 2019

Awesome This lets the user have to think about pretty printing as much. Thanks for the help with improving Calva!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants