Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No onEnterRule when Calva is not auto-indenting #383

Merged
merged 3 commits into from Oct 8, 2019
Merged

No onEnterRule when Calva is not auto-indenting #383

merged 3 commits into from Oct 8, 2019

Conversation

@PEZ
Copy link
Collaborator

PEZ commented Oct 8, 2019

Don't remove default indentation when formatAsYouType is off. (Calva does this when it is responsible for auto indentation in order to get the cursor to end up at the beginning of the line outside top-level forms.)

Fix #253

I've added a config listener that toggles the onEnterRule off when calva.fmt.formatAsYouType is disabled.

I have:

  • Read How to Contribute.
  • Made sure I am directing this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I am changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • x ] If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.

Ping: @kstehn, @cfehse

PEZ added 3 commits Oct 8, 2019
Don't remove default indentation when formatAsYouType is off

Fix #253
@PEZ PEZ merged commit b7263f5 into dev Oct 8, 2019
1 check was pending
1 check was pending
ci/circleci: install-deps CircleCI is running your tests
Details
@PEZ PEZ deleted the full-autoindent-off branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.