Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: parinfer #253

Open
allumbra opened this issue Jul 10, 2019 · 20 comments
Open

Feature request: parinfer #253

allumbra opened this issue Jul 10, 2019 · 20 comments
Labels
not-planned Nobody is working on this or planning to work on this. parinfer

Comments

@allumbra
Copy link

Do you have any plan to support parinfer? I prefer it to paredit and it would be great to have it as an integrated choice.

@PEZ
Copy link
Collaborator

PEZ commented Jul 10, 2019

Hello. I would love to support parinfer. But VSCode makes it very hard/not possible.

@allumbra
Copy link
Author

I'm currently using the Parinfer plugin - but I have to go through some effort so it doesn't conflict with the formatting and paredit features in calva

@PEZ
Copy link
Collaborator

PEZ commented Jul 10, 2019

Ah, I see. What efforts? Maybe we can ease the coexistence some.

@allumbra
Copy link
Author

Actually I spoke too soon. With the new version of Calva - I'm unable to use paredit while Calva is enabled. With the old version - I had the formatter and paredit plugins disabled and it worked.

@PEZ
Copy link
Collaborator

PEZ commented Jul 11, 2019

I don't think that Paredit can interfere with Parinfer. But the auto-formatter certainly can. You mean it doesn't work to disable calva-fmt? Can you describe a bit more how it doesn't work? The new Calva shouldn't really change this, but it was a bit of work to inline the formatter back in Calva so I might have broken something.

@allumbra
Copy link
Author

With both plugins installed - tabbing doesn't work and the parinfer control at the bottom of the screen is broken.

image

@PEZ
Copy link
Collaborator

PEZ commented Jul 14, 2019

Not sure what tabbing doesn't work means, but Calva assigns the tab key to formatting. Try assigning some other key to that.

I'll try installing both and see what I can find out.

@PEZ
Copy link
Collaborator

PEZ commented Jul 14, 2019

I can't reproduce the problem with the Parinfer mode toggle button.

Also, generally, it seems that Parinfer still works when I have both installed. Depending on workflow, Calva's autoformatter might conflict with Parinfer, so switching that off in settings might be what you want.

Again, I am not sure what tabbing is supposed to do with Parinfer, but it seems unlikely Calva would interfere apart from grabbing that key for Format current form.

@bpringe
Copy link
Member

bpringe commented Dec 16, 2020

@smothers has asked about parinfer support, so I'm reopening this to at least extend the discussion a bit since we've had questions here and there about it. I'm unfamiliar with what issues there may be both with using parinfer with Calva (user end), and with making it play nicely with Calva (our end).

@avocade
Copy link

avocade commented Jan 20, 2021

Is VSCode evolved to the point that it can match Atom’s capabilities for Parinfer’s “smart mode”?

Currently this is the only roadblock for me to go back to seriously trying VSCode again. Feel pretty stuck with Atom for now (which is extra painful now when running it on the new M1 Apple Silicon Macs... 😂).

@bpringe
Copy link
Member

bpringe commented Jan 22, 2021

@PEZ Is the one who might know, but I'm not sure how recently he's looked into it, and what the issues really were before (and maybe still are).

@PEZ
Copy link
Collaborator

PEZ commented Jan 23, 2021

The VS Code team has yet to realize that this is even an issue. I doubt smartmode will ever be something we can enjoy in this editor.

@avocade
Copy link

avocade commented Feb 1, 2021

I see, thanks! Trying the Cursive + IntelliJ combo now 👍

@bowbahdoe
Copy link

@PEZ What is it they haven't realized?

@PEZ
Copy link
Collaborator

PEZ commented Feb 6, 2021

@bowbahdoe , that the API does not allow smartmode to be reliably implemented.

PEZ added a commit that referenced this issue Nov 8, 2021
@PEZ PEZ mentioned this issue Nov 8, 2021
12 tasks
@PEZ PEZ mentioned this issue Nov 12, 2021
20 tasks
@bpringe bpringe closed this as completed in dfbfa9d Dec 1, 2021
PEZ added a commit that referenced this issue Dec 8, 2021
@cap10morgan
Copy link
Contributor

Can we re-open this? This is the only thing keeping me from using Calva, which in turns keeps me from using VS Code because any and all Clojure-in-VSCode momentum is behind Calva now. I wonder if the VSCode API has improved to the point where smartmode could now be implemented?

At any rate, parinfer does not currently exist and is still desired (by some / me). So maybe an open-but-blocked issue is a better reflection of its current / former status?

@PEZ
Copy link
Collaborator

PEZ commented Feb 8, 2024

I no longer think it is blocked by the VS Code API, because in my last attempt it seemed I found ways around this lacking.

However, it is blocked on some technical debt in Calva, which ultimately was what stopped me last time.

I don't know what to do with this issue. I don't have plans to address the lack of Parinfer, so it will take that someone else has such plans. I would definitely be there supporting anyone taking this on. Especially with the technical debt part of it.

@cap10morgan
Copy link
Contributor

cap10morgan commented Feb 8, 2024

I don't know what to do with this issue. I don't have plans to address the lack of Parinfer, so it will take that someone else has such plans. I would definitely be there supporting anyone taking this on. Especially with the technical debt part of it.

Re-open with a "help wanted" label (or similar)?

And maybe link to an issue covering the tech debt if it makes sense to split that out?

@PEZ PEZ added parinfer not-planned Nobody is working on this or planning to work on this. labels Feb 8, 2024
@PEZ PEZ reopened this Feb 8, 2024
@PEZ
Copy link
Collaborator

PEZ commented Feb 8, 2024

help-wanted sounds a bit too much like we have plans for it. 😄 But I don't mind having it opened.

@cap10morgan
Copy link
Contributor

help-wanted sounds a bit too much like we have plans for it. 😄 But I don't mind having it opened.

Cool, thanks!

Yeah, if there's a better label for it, that seems fine. I know a lot of projects use help-wanted to mean "we're OK with this conceptually if someone else wants to work on it but we aren't currently prioritizing it." Perhaps pull-requests-welcome is a better fit? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-planned Nobody is working on this or planning to work on this. parinfer
Projects
None yet
Development

No branches or pull requests

6 participants