Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL window prompt string closing #590

Merged
merged 9 commits into from
Mar 19, 2020
Merged

REPL window prompt string closing #590

merged 9 commits into from
Mar 19, 2020

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Mar 18, 2020

What has Changed?

Right now strings are not closing when a double quote is entered at the end of the string. And this also is sometimes happening for lists/vectors/etcetera. Both problems are mentioned on ClojueVerse. It turns out that the functionality for determining if we are in a string is quite broken, and the methods for closing lists too. This PR fixes both, and in addition to that improves the handling of quoted quotes inside strings.

Fixes #587

My Calva PR Checklist

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @PEZ, @kstehn, @cfehse, @bpringe

@PEZ
Copy link
Collaborator Author

PEZ commented Mar 18, 2020

For testing this PR here is a custom Calva VSIX

See the wiki about Installing VSIX packages.

@bpringe
Copy link
Member

bpringe commented Mar 18, 2020

Good stuff!

@PEZ PEZ merged commit 56770d9 into dev Mar 19, 2020
@PEZ PEZ deleted the pez/paredit-close-string-fix branch March 19, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants