Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature: reload feed lookup in CLI via hotkey (Issue #14) #20

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lamasters
Copy link

Allowed refreshing the selected feed via hotkey ALT+r

Changes

  • Added listener for hotkey combo
  • Added key control to input refresh keyword on hotkey press
  • Made feed fetching in main modular so it can be called on initial load or refresh
  • Modified defy_prompt to take input parameters for fetching feeds

@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2020

This pull request introduces 1 alert when merging eae93bb into 2836e20 - view on LGTM.com

new alerts:

  • 1 for Module-level cyclic import

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #20 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   84.79%   85.15%   +0.36%     
==========================================
  Files           4        4              
  Lines         217      229      +12     
==========================================
+ Hits          184      195      +11     
- Misses         33       34       +1     
Impacted Files Coverage Δ
core/feed.py 89.65% <0.00%> (-3.45%) ⬇️
app.py 72.09% <0.00%> (+4.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2836e20...07fae7c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2020

This pull request introduces 1 alert when merging 07fae7c into 2836e20 - view on LGTM.com

new alerts:

  • 1 for Module-level cyclic import

@lamasters lamasters marked this pull request as draft August 18, 2020 20:09
@lamasters
Copy link
Author

Looked into this, adding hotkeys requires it to be run as root in Linux. It may be better, in that case, to just enter a keyword to refresh.

@Bhupesh-V
Copy link
Owner

Hey, @lamasters are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants