Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of HEREDOC in favor of printf while printing --help text #67

Closed
Tracked by #68
Bhupesh-V opened this issue Jan 27, 2024 · 5 comments
Closed
Tracked by #68
Assignees
Labels
beginner good first issue Good for newcomers optimization Tasks related to removing and making things better ethically up for grabs

Comments

@Bhupesh-V
Copy link
Owner

Is your feature request related to a problem? Please describe.

  • Currently, while showing help text, we rely on bash HEREDOCS. This can also be achieved using multiple printf commands one-by-one.
  • Doing this helps us remove the reliance on cat command altogether from the script.

Describe the solution you'd like

Use printf variations like this for the entirety of the help text

printf "\n%s\n" "Contact 📬️: $(tput bold)varshneybhupesh@gmail.com${RESET} for assistance"

Describe alternatives you've considered

No response

@Bhupesh-V Bhupesh-V added good first issue Good for newcomers beginner up for grabs optimization Tasks related to removing and making things better ethically labels Jan 27, 2024
@T-Joseph-Kim
Copy link
Contributor

Hello I am a beginner to open source contributions, I would like to help with this issue. Is the issue located in the "ugit" bash file? Can I be assigned for this issue?

@Bhupesh-V
Copy link
Owner Author

Hello I am a beginner to open source contributions, I would like to help with this issue. Is the issue located in the "ugit" bash file? Can I be assigned for this issue?

Hey, yes its located in the ugit bash file. Welcome to foss.

I will assign the issue to you. Let me know if you need any help

@T-Joseph-Kim
Copy link
Contributor

@Bhupesh-V Hello again! I am trying to install ugit on windows and I have Git Bash, Git, and fzf correctly installed. I cloned the repo using "git clone https://github.com/Bhupesh-V/ugit.git" but I try the "ugit" command and my git bash terminal states that the command is not found. Is there something I am missing?

Thank you in advance.
image

@Bhupesh-V
Copy link
Owner Author

@Bhupesh-V Hello again! I am trying to install ugit on windows and I have Git Bash, Git, and fzf correctly installed. I cloned the repo using "git clone https://github.com/Bhupesh-V/ugit.git" but I try the "ugit" command and my git bash terminal states that the command is not found. Is there something I am missing?

Thank you in advance. image

Hey.

  1. Check if bash is available in your PATH. If not, please add that.
  2. Since you have ugit cloned locally, use bash ugit to execute the script. Ref :https://www.thewindowsclub.com/how-to-run-sh-or-shell-script-file-in-windows-10

@T-Joseph-Kim
Copy link
Contributor

Thank you for the help! I completed my pull request, please let me know if any more changes need to be made for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner good first issue Good for newcomers optimization Tasks related to removing and making things better ethically up for grabs
Projects
None yet
Development

No branches or pull requests

2 participants