This is a quick fix for #521 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There're some flags that are triggered with enable/disable, that are not oasis features, e.g., `--enable-tests`, `enable-docs`, etc. I've put them as a special args, and protected from removing. Kind of crude, but will work as a quick fix, until we will resolve this properly.
parkre
pushed a commit
to parkre/bap
that referenced
this pull request
Jul 15, 2016
…tform#522) There're some flags that are triggered with enable/disable, that are not oasis features, e.g., `--enable-tests`, `enable-docs`, etc. I've put them as a special args, and protected from removing. Kind of crude, but will work as a quick fix, until we will resolve this properly.
ivg
pushed a commit
that referenced
this pull request
Jul 15, 2016
* Goodbye segmentation faults caused by PE32+ binaries * Refactoring of namespace segment * Additional refactoring for handling of COFFObjectFiles * Refactoring of symbol and section namespaces * Removed segment constructors * Fixed narrowing conversion warnings stemming from list initializations * Correct section addresses for COFF binary objects * Make symbol namespace pretty * Additional refactoring for handling of COFFObjectFiles * Refactoring of symbol and section namespaces * Removed segment constructors * Fixed narrowing conversion warnings stemming from list initializations * Resolve x86-abi issues (#519) This PR resolves several x86 abi issues that were found by a new testsuite: 1. Currently x86 abi don't know how to pass arrays of unknown sizes. Different ABI allows to pass them via registers, if certain condition holds and size is known, if the size is unknown, then they are usually passed as a pointer. Since, currently the support for x86 ABI is preliminary I fixed this locally in the `c/posix`. 2. Added ABI autodetection. This is a heuristics that may detect that a binary has MS ABI. A better approach would be to store the information about original file format. Knowing that the file is in PE32 or PE32+ format is a much better heuristic to guess that it is for Windows. 3. Added demangling for Win32 files. As a result, now Saluki is able to work on MS binaries out of box, and even without the IDA help, as PE32 binaries usually have much more symbolic information. * Integrate testsuite (#520) * integrated testsuite repository * added the check phase to opam file now every build will also checkout the testuite and run all tests. * initialize submodule only if in the git repo. Since when we're pinned from opam, we're no longer in git, but opam should recursively fetch all submodules for us. * added dejagnu dependency. * bumped testsuite to a newer version that supports older Tcl * This is a quick fix for #521 (#522) There're some flags that are triggered with enable/disable, that are not oasis features, e.g., `--enable-tests`, `enable-docs`, etc. I've put them as a special args, and protected from removing. Kind of crude, but will work as a quick fix, until we will resolve this properly. * Correct section addresses for COFF binary objects * Make symbol namespace pretty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're some flags that are triggered with enable/disable, that are not
oasis features, e.g.,
--enable-tests,enable-docs, etc. I've putthem as a special args, and protected from removing. Kind of crude, but
will work as a quick fix, until we will resolve this properly.