Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adapt to Auditok v0.1.8 #137

Closed
PumpkinCheshire opened this issue Aug 20, 2020 · 5 comments · Fixed by #144
Closed

Consider adapt to Auditok v0.1.8 #137

PumpkinCheshire opened this issue Aug 20, 2020 · 5 comments · Fixed by #144

Comments

@PumpkinCheshire
Copy link

Auditok had stayed at v0.1.8 for 2 years. Should be very stable and useful. Downgrade the auditok when using autosub can be very frustrating.

Thanks for your hard work, this autosub is very useful.

@BingLingGroup
Copy link
Owner

It seems the higher version of Auditok doesn't have any compatibility issues. So commit 3489be8 just simply changes the install_requires in setup.py.

@PumpkinCheshire
Copy link
Author

PumpkinCheshire commented Oct 5, 2020 via email

@BingLingGroup
Copy link
Owner

BingLingGroup commented Oct 7, 2020

It seems that I finally figure out what's going right now.
Auditok v0.1.8 which was released on 2018.11.01 is the same with the version on PyPI. If you just use pip to install Auditok latest version from PyPI, you will be all right.
But the latest Auditok in github repo, especially the codes after commit amsehili/auditok@f6936a3, has changed some method names which was incompatible with the v0.1.8 release. More importantly it's not a stable release and the document hasn't changed since Auditok v0.1.5, especially considering most people install their Auditok by PyPI instead of directly from github. So it's not either appropriate or convenient to refactor the codes in autosub to use the new method names.
If you still want autosub to use the latest codes in Auditok, you can modify it yourself. The changes were written in the comment amsehili/auditok@f6936a3#diff-6d3f7ac4b238d7860202726f71cbc465L201-L202.

@PumpkinCheshire
Copy link
Author

The dev branch seems no longer working because of the recently upgrade of Auditok 0.2.0 . Please consider restrict auditok version or try to be compatible with the new version? Also, any ideas on google's new google-cloud-speech api?

@BingLingGroup
Copy link
Owner

It's still working. The Auditok version has been restricted in the setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants