fix multiple issues #144

jitingcn · 2020-10-01T20:08:10Z

This pull request should fix #142, close #137 and close #143

The major changes are:
ci: add ci script for automated testing, switch to GitHub Actions

fix(sub_utils.py): add missing separator and prevent blank input from being accepted

refactor: fix breaking changes in google-cloud-speech v2.0.0 (untest)

Please review and suggestions are welcome.

Add missing separator Prevent blank input from being accepted

Migrate google-cloud-speech to 2.0.0 (breaking change by upstream) Allow auditok v0.1.8 be used https://github.com/googleapis/python-speech/blob/master/UPGRADING.md

fix permission and filename disable youtube-dl progress bar separate test job

This reverts commit 623b007.

jitingcn · 2020-10-01T21:35:29Z

with the option -der:

Translating text from "en" to "zh-cn".
Bilingual subtitles file created at "/home/runner/work/autosub/autosub/test.en&zh-cn.srt".
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.5/x64/bin/autosub", line 11, in <module>
    load_entry_point('autosub==0.5.7a0', 'console_scripts', 'autosub')()
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/autosub/__init__.py", line 159, in main
    cmdline_utils.audio_or_video_prcs(args,
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/autosub/cmdline_utils.py", line 1691, in audio_or_video_prcs
    sub_utils.pysubs2_ssa_event_add(
  File "/opt/hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/autosub/sub_utils.py", line 664, in pysubs2_ssa_event_add
    event.start = src_ssafile.events[i].start
IndexError: list index out of range
Error: Process completed with exit code 1.

BingLingGroup · 2020-10-04T11:59:33Z

Thanks for your pull request.

jitingcn added 4 commits October 2, 2020 02:13

change ci to github actions

6d7330a

fix output file path

dbe6874

Add missing separator Prevent blank input from being accepted

Update dependencies

623b007

Migrate google-cloud-speech to 2.0.0 (breaking change by upstream) Allow auditok v0.1.8 be used https://github.com/googleapis/python-speech/blob/master/UPGRADING.md

ci(github): fix script

7535b3d

fix permission and filename disable youtube-dl progress bar separate test job

jitingcn force-pushed the fix-1 branch from af9447b to 7535b3d Compare October 1, 2020 20:21

jitingcn marked this pull request as ready for review October 1, 2020 20:22

jitingcn added 2 commits October 2, 2020 05:00

Revert "Update dependencies"

49724c9

This reverts commit 623b007.

fix dependencies

3489be8

fix: out of range when output bilingual subtitles with -der option

277e8bf

jitingcn force-pushed the fix-1 branch from f8cd51a to 277e8bf Compare October 1, 2020 22:44

fix pylint

b34cd5b

BingLingGroup added Status: Accepted Status: In Progress Type: Bug Type: Enhancement labels Oct 4, 2020

BingLingGroup merged commit 23dd7a0 into BingLingGroup:dev Oct 4, 2020

BingLingGroup added Status: Completed and removed Status: Accepted Status: In Progress labels Oct 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix multiple issues #144

fix multiple issues #144

jitingcn commented Oct 1, 2020 •

edited

Loading

jitingcn commented Oct 1, 2020

BingLingGroup commented Oct 4, 2020

fix multiple issues #144

fix multiple issues #144

Conversation

jitingcn commented Oct 1, 2020 • edited Loading

jitingcn commented Oct 1, 2020

BingLingGroup commented Oct 4, 2020

jitingcn commented Oct 1, 2020 •

edited

Loading