Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding eosc-pilot/1.0-remastering container #289

Merged
merged 1 commit into from Oct 18, 2018
Merged

Adding eosc-pilot/1.0-remastering container #289

merged 1 commit into from Oct 18, 2018

Conversation

pditommaso
Copy link
Contributor

Submitting a Container

(If you're requesting for a new container, please check the procedure described here.

Check BioContainers' Dockerfile specifications

Checklist

  1. Misc
  • My tool doesn't exist in BioConda
  • The image can be built
  1. Metadata
  • LABEL base_image
  • LABEL version
  • LABEL software.version
  • LABEL about.summary
  • LABEL about.home
  • LABEL about.license
  • MAINTAINER
  1. Extra (optionals)
  • I have written tests in test-cmds.txt
  • LABEL extra.identifier
  • LABEL about.documentation
  • LABEL about.license_file
  • LABEL about.tags

Check BioContainers' Dockerfile metadata

@pditommaso pditommaso mentioned this pull request Oct 18, 2018
Closed
@osallou
Copy link
Contributor

osallou commented Oct 18, 2018

label software should match directory name (and is linked to container name with its strict rules)
you have: software="EGA-CRG EOSC-Pilot project"
should be: software=eosc-pilot

@osallou
Copy link
Contributor

osallou commented Oct 18, 2018

please specify in about.license_file the location of the license file in the container, or a url to license for this release of the software.

@osallou
Copy link
Contributor

osallou commented Oct 18, 2018

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

@pditommaso
Copy link
Contributor Author

Fixed.

@pditommaso
Copy link
Contributor Author

check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

this is basically a multi tools container including R + picard=2.9 + bwa=0.7.15 + fastqc=0.11.5 + sambamba=0.6.6 + tabix

Should I include a biotools ID for each of them ?

@osallou
Copy link
Contributor

osallou commented Oct 18, 2018

No eosc-pilot/1.0-remastering/test-cmds.txt (test file) present, skipping tests

@osallou
Copy link
Contributor

osallou commented Oct 18, 2018

no biotools id is needed it as a multi tool.
This is an automated comment based on dockerfile analysis... :-)

merging it, thanks

@osallou osallou merged commit 10dd911 into BioContainers:master Oct 18, 2018
@osallou
Copy link
Contributor

osallou commented Oct 18, 2018

please specify in about.license_file the location of the license file in the container, or a url to license for this release of the software.

@osallou
Copy link
Contributor

osallou commented Oct 18, 2018

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

@osallou
Copy link
Contributor

osallou commented Oct 18, 2018

No eosc-pilot/1.0-remastering/test-cmds.txt (test file) present, skipping tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pditommaso @osallou