Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Combinatorics dependency #158

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Remove Combinatorics dependency #158

merged 1 commit into from
Apr 29, 2021

Conversation

TransGirlCodes
Copy link
Member

@TransGirlCodes TransGirlCodes commented Apr 29, 2021

Types of changes

This PR implements the following changes:
(Please tick any or all of the following that are applicable)

  • ✨ New feature (A non-breaking change which adds functionality).
  • πŸ› Bug fix (A non-breaking change, which fixes an issue).
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to change).

πŸ“‹ Additional detail

β˜‘οΈ Checklist

  • 🎨 The changes implemented is consistent with the julia style guide.
  • πŸ“˜ I have updated and added relevant docstrings, in a manner consistent with the documentation styleguide.
  • πŸ“˜ I have added or updated relevant user and developer manuals/documentation in docs/src/.
  • πŸ†— There are unit tests that cover the code changes I have made.
  • πŸ†— The unit tests cover my code changes AND they pass.
  • πŸ“ I have added an entry to the [UNRELEASED] section of the manually curated CHANGELOG.md file for this repository.
  • πŸ†— All changes should be compatible with the latest stable version of Julia.
  • πŸ’­ I have commented liberally for any complex pieces of internal code.

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #158 (1d2e0ca) into v3 (1bc7932) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #158      +/-   ##
==========================================
- Coverage   80.16%   80.12%   -0.04%     
==========================================
  Files          31       31              
  Lines        2178     2179       +1     
==========================================
  Hits         1746     1746              
- Misses        432      433       +1     
Flag Coverage Ξ”
unittests 80.12% <ΓΈ> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
src/BioSequences.jl 0.00% <ΓΈ> (ΓΈ)
src/longsequences/constructors.jl 77.41% <0.00%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1bc7932...1d2e0ca. Read the comment docs.

@TransGirlCodes TransGirlCodes merged commit 80a1c35 into v3 Apr 29, 2021
@TransGirlCodes TransGirlCodes deleted the no_combinatorics branch April 29, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant