Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project TOML file #63

Merged
merged 6 commits into from
May 12, 2019
Merged

Project TOML file #63

merged 6 commits into from
May 12, 2019

Conversation

TransGirlCodes
Copy link
Member

This PR removes any dependencies no longer used by the BioSequences module, and will replace the REQUIRE file with a Project.toml

Ben J. Ward added 3 commits May 11, 2019 00:04
With the IO submodules removed in #64, there is no longer any need for Automa as a dependency.
Version 2 of BioSequences is dropping the IO submodules, and so BufferedStreams is no longer needed.
@TransGirlCodes TransGirlCodes changed the title Project files Project TOML file May 10, 2019
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #63 into version2 will increase coverage by 7.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           version2      #63      +/-   ##
============================================
+ Coverage     73.73%   81.21%   +7.48%     
============================================
  Files            47       47              
  Lines          1938     2316     +378     
============================================
+ Hits           1429     1881     +452     
+ Misses          509      435      -74
Impacted Files Coverage Δ
src/search/re.jl 83.52% <ø> (+3.88%) ⬆️
src/BioSequences.jl 50% <ø> (+50%) ⬆️
src/biosequences/biosequence.jl 60.71% <ø> (+10.71%) ⬆️
src/minhash.jl 70.73% <ø> (+0.73%) ⬆️
src/biosequences/printing.jl 48.27% <0%> (-3.58%) ⬇️
src/skipmers/transformations.jl 100% <0%> (ø) ⬆️
src/biosequences/predicates.jl 97.14% <0%> (+0.36%) ⬆️
src/longsequences/randseq.jl 96.77% <0%> (+0.47%) ⬆️
src/longsequences/constructors.jl 95.12% <0%> (+0.52%) ⬆️
src/biosequences/indexing.jl 92.85% <0%> (+0.54%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd65804...d0aae9a. Read the comment docs.

@TransGirlCodes TransGirlCodes force-pushed the project-files branch 10 times, most recently from bf6e852 to 155aab9 Compare May 11, 2019 23:24
@TransGirlCodes TransGirlCodes merged commit 24b7400 into version2 May 12, 2019
@TransGirlCodes TransGirlCodes deleted the project-files branch May 12, 2019 12:27
@cecileane
Copy link

Do you have plans to merge this version into master, so that projects using BioSequences can also use their own Project.toml and register new versions on the general registry?

@TransGirlCodes
Copy link
Member Author

TransGirlCodes commented Jun 30, 2019

I was going to leave master as it is until the version2 branch is in a state I am happy with, at which point master will be updated and a V2.X of BioSequences, with a new API and sequence types will be released. The work for BioSequences v2.0 is not far from completion now: one or two weeks should do it with the time I have available.

As far as I can tell, BioSequences 1.1 using REQUIRE hasn't been causing any issues, I've been developing and releasing packages that use Project.toml and BioSequences without an issue so far.

@cecileane
Copy link

Oh it makes complete sense.

I was under the impression that "A package with a project file cannot depend on one without a project file" (from here). But this may not be a problem for packages that were in METADATA before the switch to the General registry, as all these packages are in there, and with their own uuid. Sorry for the trouble.

Looking forward to BioSequences v2.0!

TransGirlCodes pushed a commit that referenced this pull request Aug 4, 2019
* Rename types in BioSequences (#53)

* Add unsafe_setindex for more Base.setindex methods (#54)

* Move and generalise sequence transformation methods (#56)

* Reworked random LongSequence generation (#55)

* Remove IO submodules (#62)

* Remove the ABIF submodule

* Project TOML file (#63)

* Remove Automa

* Replace BioCore with BioGenerics

* SkipmerFactory (#57)

* Add findnext, findprev and each methods for functions

* Refactor naive counting and gc_counting and add counting manual page

* Update transforms to work for BigMers and actually test BigMers

* Redux the bit-parallel mismatch counter methods

* Add a paired sequence bitpar function compiler

* Match counter redux

* Ambiguous site counting redux

* Gap site counting redux

* Certain site counting redux

* Remove old site counting system and document the new one

* Remove redundant gc_count function for LongSequences

* Redux the mer iteration interface and add sections to the manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants