Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BioSequences/BioSymbols to v3/v5 #66

Merged
merged 2 commits into from
Feb 19, 2022

Conversation

jakobnissen
Copy link
Member

This creates a new version of FASTX using the latest BioSequences/BioSymbols. It contains no breaking changes.

I think FASTX could use a more thorough release where e.g. the tests are fixed up. But that's a larger undertaking, this is just to allow BioSequences v3 to be used with FASTX.

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #66 (00094c5) into master (0093974) will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files          12       12           
  Lines         660      660           
=======================================
  Hits          557      557           
  Misses        103      103           
Flag Coverage Δ
unittests 84.39% <85.71%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fasta/record.jl 81.25% <75.00%> (ø)
src/fastq/record.jl 84.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0093974...00094c5. Read the comment docs.

@jakobnissen jakobnissen merged commit b153739 into BioJulia:master Feb 19, 2022
jakobnissen added a commit to jakobnissen/FASTX.jl that referenced this pull request Feb 20, 2022
* Bump BioSequences/BioSymbols to v3/v5

* Bump Julia version
jakobnissen added a commit that referenced this pull request Feb 20, 2022
* Bump BioSequences/BioSymbols to v3/v5

* Bump Julia version
jakobnissen added a commit to jakobnissen/FASTX.jl that referenced this pull request Aug 9, 2022
* Bump BioSequences/BioSymbols to v3/v5

* Bump Julia version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant