Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReTest #84

Merged
merged 8 commits into from
Aug 16, 2022
Merged

Use ReTest #84

merged 8 commits into from
Aug 16, 2022

Conversation

kescobo
Copy link
Member

@kescobo kescobo commented Aug 14, 2022

Branched off of #68 . Closes #83

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #84 (e252715) into master (f44c498) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          11       11           
  Lines         629      629           
=======================================
  Hits          568      568           
  Misses         61       61           
Flag Coverage Δ
unittests 90.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/FASTX.jl 91.17% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kescobo
Copy link
Member Author

kescobo commented Aug 14, 2022

@jakobnissen So this is a bummer

How married to the nesting testsets are you? I could preserve it by making each of the sub-files a new module (eg TestFASTA.IO - it would be a bit of a hassle since each thing would need to re-do imports etc. Another option is to just include the name in all of the testsets (eg @testset "IO - Reader Basics" begin. Then one can do `retest(TestFASTA, "IO") to run them in isolation.

I'm partial to the last one. You can pass multiple filters, so eg if you want the "basic" tests, but only the ones from "IO", you can do retest(TestFASTA, "IO", "basic").

@kescobo
Copy link
Member Author

kescobo commented Aug 14, 2022

Argh, actually, that doesn't work as well because it doesn't pick up on changes to the included files with Revise. I'll just make submodules.

@jakobnissen
Copy link
Member

I don't really have any opinions, since I haven't used ReTest for any real project yet.

@kescobo kescobo marked this pull request as ready for review August 15, 2022 16:53
@kescobo
Copy link
Member Author

kescobo commented Aug 15, 2022

Alright, I think this should work. I've added a test/README.md to describe what to do, please take a look and let me know if it makes sense.

@kescobo
Copy link
Member Author

kescobo commented Aug 15, 2022

Hm... don't see why julia 1.6 would be different here.

@kescobo
Copy link
Member Author

kescobo commented Aug 15, 2022

Oh, the problem is windows/mac, not the julia version 🤔

I only have linux box, anyone with mac/windows have a thought?

@jakobnissen
Copy link
Member

It could be having different files whose names differ by case only? I think Windows paths are case insensitive

@kescobo
Copy link
Member Author

kescobo commented Aug 15, 2022

@jakobnissen OK, I think this is good to go

Copy link
Member

@jakobnissen jakobnissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real nice.

Copy link
Member

@jakobnissen jakobnissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real nice.

src/FASTX.jl Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
@jakobnissen jakobnissen merged commit 5250a27 into master Aug 16, 2022
@jakobnissen jakobnissen deleted the kescobo/retest branch August 16, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ReTest or similar niceness?
2 participants