Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for string data changes #41

Merged
merged 1 commit into from
Jan 9, 2017
Merged

Fix for string data changes #41

merged 1 commit into from
Jan 9, 2017

Conversation

musm
Copy link
Contributor

@musm musm commented Jan 9, 2017

No description provided.

@musm musm changed the title Update deprecated takebuf_array and takebuf_string Fix for string data changes Jan 9, 2017
@musm
Copy link
Contributor Author

musm commented Jan 9, 2017

close #41

@TransGirlCodes
Copy link
Member

Thanks @musm! 👍 When the tests go green I'll merge this!

@musm
Copy link
Contributor Author

musm commented Jan 9, 2017

ok it's now green!

to update the other deprecation warnings we need: https://github.com/BioJulia/BufferedStreams.jl/pull/27/files
and it will also need to be tagged!

@TransGirlCodes TransGirlCodes merged commit bc80187 into BioJulia:master Jan 9, 2017
@TransGirlCodes
Copy link
Member

Ok merged!

@musm musm mentioned this pull request Jan 9, 2017
Closed
TransGirlCodes pushed a commit that referenced this pull request Jan 10, 2017
@musm
Update to remove string.data (#41)
c4ecdc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@musm @TransGirlCodes