Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting definitions of "devel"/"release" between actual Bioconductor and bioconductor_docker #37

Closed
bschilder opened this issue Oct 27, 2021 · 12 comments
Assignees

Comments

@bschilder
Copy link

bschilder commented Oct 27, 2021

Unless I'm missing something, there appears to be a lag between when Bioconductor changes the previous devel to become the current release (3.14 as of today), and when the bioconductor/bioconductor_docker container is updated (it currently lists 3.14 as the devel and 3.13 as the release, which is no longer true).
https://hub.docker.com/layers/bioconductor/bioconductor_docker/devel/images/sha256-5edc02a68f1bbee9db21950b95c133aaab97e15781d3cc1690fed41b3689c2d2?context=explore

This causes (GitHub Action) workflows that depend on harmonized devel/release naming schemes across Bioconductor and bioconductor_docker to break.

How long of a delay is there between when a new version of Bioconductor is released and when this bioconductor_docker is updated? Is this something that is currently automated?

GHA workflow

Example GHA workflow output

@bschilder
Copy link
Author

This seems to be a recurring issue that could potentially be addressed with automated updates to bioconductor_docker every time a new version of Bioconductor is released:
#29
#17
#8

@nturaga
Copy link
Collaborator

nturaga commented Oct 28, 2021

Yes, we check the docker image once the release is done to make sure everything is working as expected.

Reasons:

  • We currently do not have automated tests for our docker images. We run some manual tests.

  • We make sure all the packages are being installed without issues (other than those reported on the build system)

Usually, it's just the day after the release, i.e today by end of day or early tomorrow.

@bschilder
Copy link
Author

Thanks so much for the info and the quick reply @nturaga! See here #29 for some potential ideas.

@mblue9
Copy link

mblue9 commented Oct 30, 2021

Hi reading above, should a docker image for RELEASE_3_14 be available here now https://hub.docker.com/r/bioconductor/bioconductor_docker/tags ?

Can only see RELEASE_3_13 and devel which uses 3.15. Be great to get 3.14 for a workshop we have on Monday, actions currently failing due to having no 3.14 Docker available https://github.com/tidytranscriptomics-workshops/rpharma2021_tidytranscriptomics/actions

@nturaga
Copy link
Collaborator

nturaga commented Oct 31, 2021

It's available now. Please check.

@nturaga
Copy link
Collaborator

nturaga commented Oct 31, 2021

@mblue9 Let me know if it worked?

@mblue9
Copy link

mblue9 commented Oct 31, 2021

Trying it now & looks like it's working. Thanks a lot @nturaga !!

@nturaga nturaga self-assigned this Oct 31, 2021
@nturaga nturaga closed this as completed Jan 5, 2022
@LiNk-NY
Copy link
Contributor

LiNk-NY commented Jan 6, 2023

Hi Brian, @bschilder
Regarding your note here: https://github.com/marketplace/actions/rworkflows Acknowledgements > Details
"Often" is an overstatement. The devel container does take a day or two to get updated immediately after the release. Our updates are increasingly automated thanks to Alex @almahmoud
Throughout the rest of the six month period, the devel container corresponds to the devel version of Bioconductor.

@bschilder
Copy link
Author

Hi Brian, @bschilder Regarding your note here: https://github.com/marketplace/actions/rworkflows Acknowledgements > Details "Often" is an overstatement. The devel container does take a day or two to get updated immediately after the release. Our updates are increasingly automated thanks to Alex @almahmoud Throughout the rest of the six month period, the devel container corresponds to the devel version of Bioconductor.

I was referring to the lag after updates, but I can clarify in the description. Great to hear improvements in automation and checking are happening! Thanks for the continued efforts.

@LiNk-NY
Copy link
Contributor

LiNk-NY commented Jan 6, 2023

Thanks for the clarification.
The lag is due to the release events schedule and the actual time it takes to update them. The containers get updated post-release.

@bschilder
Copy link
Author

bschilder commented Jan 7, 2023

The lag is due to the release events schedule and the actual time it takes to update them. The containers get updated post-release.

The note now reads:

NOTE: Whenever a new version of Bioconductor is released,
the bioconductor/bioconductor_docker container will often lag behind the actual Bioconductor releases
for up to several days, due to the time it takes to update the container.
This means that sometimes "devel" in Bioconductor/bioconductor_docker is actually referring to the "release"
version of Bioconductor. See this Issue
for details.

Does that seem accurate to you @LiNk-NY ?

@LiNk-NY
Copy link
Contributor

LiNk-NY commented Jan 9, 2023

Looks good. The second to last sentence might going into too much detail but you could say that during that period, devel still refers to the previous release's devel which is the current release version (if this info is necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants