-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM→ BiomedSciAI Github org transfer adjustments #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Seems like there are no python builds on Ubuntu https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
Don't cancel other the rest of the python version builds if only one (or more, just make them independent) fail. It is not uncommon that only certain python versions fail due to dependency hell.
Since `hemm` failed due to no Pytorch
Also rename job
Test whether only one version succeeding is a matter of some resource parallel allocation mutex.
Revert the `fail-fast`, but now try to ensure that there are no parallel jobs by using `max-parallel`
Currently causes two main issues: - No `normalize` in `LinearRegression`. Easy, just need to update tests to use a Pipeline - Force singular feature type in pandas columns (harder) Harder, will require a safe-join mechanism when adding treatment as variable.
Workflow's name appear in the badge, so change that to a short `Build` instead of a long "Build and install causallib". Consequentially change the yml file from `test` to `build` to preserve consistency Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Currently causes a problem with matplotlib when plotting `fill_between` in the calibration plot tests
Github Actions queue fix
Github Actions do not support python 3.6 on `ubuntu-latest`*, and since python 3.6 is well after its end of life, I see no use in hacking a way for it work. Farewell python 3.6, you were great *``` Error: The version '3.6' with architecture 'x64' was not found for Ubuntu 22.04. The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json ```
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Goodbye, Travis, thank you for your service. Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Check whether build now passes when removing the single process constraint and allowed to run in parallel
Migrate to GitHub actions
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary changes after transferring causallib from the IBM org on github to the BiomedSciAI org.
Including: