Blacklist not applied to downloads

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Add tag to blacklist
2. Generate page with images with blacklisted tag
3. Notice the warning working and ignore images working properly (if checked in 
options)
4. Download the page (notice correct 'false' setting for download images with 
blacklisted tags) and go to the download location

What is the expected output? What do you see instead?
Notice that all images have been downloaded, even the ones with blacklisted 
tags. Expected output is only the non-blacklist images.

What version of the product are you using? On what operating system?
2.1.1, Win7

Please provide any additional information below.

Original issue reported on code.google.com by mem3.yhe...@gmail.com on 1 Aug 2011 at 1:41

[GoogleCodeExporter]

Indeed, now that you mention it, it does not work. It will be fixed in the 2.2 
version (available in a few days), thanks for reporting.

Original comment by bio.nus@hotmail.fr on 6 Aug 2011 at 9:59

• Changed state: Started

[GoogleCodeExporter]

Should be fixed now with the latest version (2.2.0). :)

Original comment by bio.nus@hotmail.fr on 8 Aug 2011 at 7:45

• Changed state: Fixed

[GoogleCodeExporter]

Thanks for the effort but the issue is still there. I reinstalled to 2.2.0 and 
tried the same procedure above several times. Again it downloaded 20/20 and 
didn't ignore the ones with blacklisted tags. The setting was false (but I also 
tried true, same result, so that's not it). When saving as %all% you can 
clearly see the files with blacklist tags in their file name being saved, but 
when browsing the images are hidden properly (so blacklist works when browsing 
just not downloading). I also tried resetting/retyping the blacklist.

It must be something with the check when processing downloads. When processing 
next image, it should check for blacklist tags and ignore, not even bother 
starting download.

I like your program very much, there's a lack of this kind of thing (at least 
with as broad of a support for websites). I also had one suggestion/request. 
Could you possibly add %tag% (ore something like that) token so that it would 
be possible to save the files with the search tag only (opposed to %all%). So 
ex. searching for rose we could save as rose-%md5%.%ext% (some of the images 
have a lot of tags and its just not practical to use %all% you see)

Original comment by mem3.yhe...@gmail.com on 8 Aug 2011 at 11:12

[GoogleCodeExporter]

Ok, I think I know why the bug remains for you. I'm working on it and will 
release 2.2.1 in a few moments.
What's your "filename" setting?

About your suggestion, it is already done, but not yet documented. You can use 
the %search% token (all searched tags), and %search_1% (first tag in the 
search), %search_2%, etc. In your example "%search%-%md5%.%ext%".

Original comment by bio.nus@hotmail.fr on 8 Aug 2011 at 11:20

• Changed state: Started

[GoogleCodeExporter]

Issue 20 has been merged into this issue.

Original comment by bio.nus@hotmail.fr on 8 Aug 2011 at 11:21

[GoogleCodeExporter]

That was fast. I tried %all%.%ext% and %md5%.%ext%, happens with both.

Original comment by mem3.yhe...@gmail.com on 8 Aug 2011 at 11:29

[GoogleCodeExporter]

O thanks for %search%, please remove issue21 suggestion, wasn't sure if you 
read the closed ones so I reposed in the proper manner.

Original comment by mem3.yhe...@gmail.com on 8 Aug 2011 at 11:31

[GoogleCodeExporter]

Was what I thought then. I should upload the 2.2.1 version in about ten minutes.

Original comment by bio.nus@hotmail.fr on 8 Aug 2011 at 11:32

[GoogleCodeExporter]

Ok, I'll remove issue 21. But %search% won't work for you until 2.2.1 anyway.

Original comment by bio.nus@hotmail.fr on 8 Aug 2011 at 11:35

[GoogleCodeExporter]

This issue was closed by revision r196.

Original comment by bio.nus@hotmail.fr on 8 Aug 2011 at 11:47

• Changed state: Fixed

[GoogleCodeExporter]

Do you confirm it is working in 2.2.1?

Original comment by bio.nus@hotmail.fr on 8 Aug 2011 at 11:59