Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markup decorative hr tags as decorative #4212

Closed
StephDriver opened this issue May 30, 2024 · 4 comments
Closed

markup decorative hr tags as decorative #4212

StephDriver opened this issue May 30, 2024 · 4 comments
Labels
a11y Issues that relate to acessibility

Comments

@StephDriver
Copy link
Contributor

<hr> has been used for visual formatting, but it is focusable and read as 'separator, dimmed' which is confusing.

update the markup so that these are not focusable and are not described by screen readers.

examples:
image
The almost invisible pale line under 'Research Article' is an <hr>.

@StephDriver StephDriver added the a11y Issues that relate to acessibility label May 30, 2024
@StephDriver
Copy link
Contributor Author

from #4194

  • Sample 5.1, item 7. the line under this seems to be decorative, but is read out as 'separator, dimmed'
  • Sample 5.3, item 3. "separator, dimmed" the <hr> following the about and before news is read aloud, but this is decorative.

@ajrbyers
Copy link
Member

I think we will need to assess the use of hr tags. They are legitimately separators used the breakup content so no technically “decorative”.

@StephDriver
Copy link
Contributor Author

StephDriver commented Sep 30, 2024

It was the 'dimmed' part that felt confusing in a 'why do I need to know this' way. Perhaps the dimming can be done through the CSS instead?

Further, I think the HR as a semantic element is only when used to separate paragraphs. In the above example I think it is underlying a heading, which is decorative.

see <hr>: The Thematic Break on MDN

The <hr> element represents a thematic break between paragraph-level elements: for example, a change of scene in a story, or a shift of topic within a section.

For now, I think a review of HR use would make sense if combined with

@StephDriver
Copy link
Contributor Author

closing because it is now part of #4232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues that relate to acessibility
Projects
Status: Done
Development

No branches or pull requests

2 participants