Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure modal a11y improvements #4239

Open
StephDriver opened this issue Jun 3, 2024 · 1 comment
Open

Figure modal a11y improvements #4239

StephDriver opened this issue Jun 3, 2024 · 1 comment
Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development. priority-high High priority priority-urgent size L Large

Comments

@StephDriver
Copy link
Contributor

StephDriver commented Jun 3, 2024

from #4194

  • Sample 4, item 21. link to enlarge the figure is just 'figure 1' this needs to be more descriptive.
  • Sample 4, item 22. having enlarged the figure, the modal is not navigable - no way to dismiss it.
  • Sample 4, item 32. similar issues with Table 1 as with Figure 1 above. Cannot navigate to the close button, and end up outside the modal, but without it being dismissed.

Consider - if the enlargement has no difference in alternative text to the smaller version, making it obvious in the link so that users can decided whether to stick with the main article instead.

@StephDriver StephDriver added the a11y Issues that relate to acessibility label Jun 3, 2024
@joemull
Copy link
Member

joemull commented Oct 24, 2024

Refinement: We need to consider this primarily for the clean theme. The bug was discovered when testing on OLH theme, but clean theme should be prioritized. The JS utility we use for this feature is the same on both, though the HTML and CSS would of course be theme-specific.

We should consider whether there is an accessible bootstrap-provided utility for this that better integrates with clean HTML and CSS than the lightbox utility that we are currently using.

An even simpler alternative is the standard HTML element popover which should be considered if it is the simplest solution.

@joemull joemull added size L Large dev-ready This issue has been refined and is ready for development. labels Oct 24, 2024
@StephDriver StephDriver added the VPAT Issue prioritised for VPAT improvements. label Oct 24, 2024
@joemull joemull added priority-high High priority priority-urgent and removed VPAT Issue prioritised for VPAT improvements. labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development. priority-high High priority priority-urgent size L Large
Projects
Status: Sent to Dev
Development

No branches or pull requests

2 participants