Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer review invite #3490

Merged
merged 17 commits into from
May 10, 2023
Merged

Peer review invite #3490

merged 17 commits into from
May 10, 2023

Conversation

ajrbyers
Copy link
Member

  • Adds a new view for editors to import large numbers of reviewers from CSV
  • When a review round has more than 4 reviewers the reviewer display will collapse into a table
  • Adds a new setting to disable review decisions, uses a new default called DECISION_NO_RECOMMENDATION, reviewers will now see this as an option in normal reviews
  • Added a setting to make Open Review Permission opt-in by default

@ajrbyers ajrbyers changed the base branch from master to b_1_5_0 April 18, 2023 10:25
@ajrbyers ajrbyers marked this pull request as draft April 18, 2023 10:25
Base automatically changed from b_1_5_0 to master May 9, 2023 09:06
@ajrbyers ajrbyers changed the base branch from master to b_1_5_0 May 10, 2023 10:13
@ajrbyers ajrbyers marked this pull request as ready for review May 10, 2023 10:48
@ajrbyers ajrbyers requested a review from mauromsl May 10, 2023 10:48
mauromsl
mauromsl requested changes May 10, 2023
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inline.

I think we also need to document the new behaviour of these open review settings

src/review/forms.py Outdated Show resolved Hide resolved
src/review/forms.py Outdated Show resolved Hide resolved
src/review/models.py Outdated Show resolved Hide resolved
src/review/models.py Outdated Show resolved Hide resolved
src/utils/testing/helpers.py Outdated Show resolved Hide resolved
src/review/const.py Show resolved Hide resolved
@mauromsl mauromsl merged commit eebf16b into b_1_5_0 May 10, 2023
@mauromsl mauromsl deleted the peer-review-invite branch May 10, 2023 11:15
@ajrbyers ajrbyers mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajrbyers @mauromsl